Bug 708554
| Summary: | Review Request: umph - Command line tool for parsing video links from Youtube feeds | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicoleau Fabien <nicoleau.fabien> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | umph-0.1.8-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-26 18:53:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 708711 | ||
|
Description
Nicoleau Fabien
2011-05-27 23:56:38 UTC
Review: - afaik BR/R are ok (don't know perl, so can't be absolutely sure) - macros everywhere - arch ok - %build ok - %doc ok - rpmlint ok: $ rpmlint ~/rpmbuild/RPMS/noarch/umph-0.1.8-1.fc15.noarch.rpm ~/rpmbuild/SRPMS/umph-0.1.8-1.fc15.src.rpm umph.noarch: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists umph.src: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists umph.src: W: invalid-url Source0: http://umph.googlecode.com/files/umph-0.1.8.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 3 warnings. All false positives, downloading with spectool worked. Is a correct url... Needswork: - License is wrong: it's not GPLv3 (=GPLv3 only), it's: GPLv3+ - same issue like with dependant package: compression of makefile could change, please use %{name}.1.* Please fix the 2 needswork and it's: ############################################################## APPROVED Thank you for the review. I'll fix the licence and use %{name}.1.* before the import.
New Package SCM Request
=======================
Package Name: umph
Short Description: Command line tool for parsing video links from Youtube feeds
Owners: eponyme
Branches: f15
InitialCC:
Git done (by process-git-requests). Added f16. umph-0.1.8-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/umph-0.1.8-2.fc15 umph-0.1.8-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/umph-0.1.8-2.fc16 umph-0.1.8-2.fc15 has been pushed to the Fedora 15 testing repository. umph-0.1.8-2.fc15 has been pushed to the Fedora 15 stable repository. umph-0.1.8-2.fc16 has been pushed to the Fedora 16 stable repository. |