Bug 708696
| Summary: | fldigi crashes when started | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Philip Heron <phil> | ||||
| Component: | fldigi | Assignee: | Randy Berry <randyn3lrx> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 15 | CC: | bob, randyn3lrx, riel | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fldigi-3.21.35-1.fc15 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-06-29 22:03:18 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Philip Heron
2011-05-28 21:21:52 UTC
Some more information from GDB:
[Thread debugging using libthread_db enabled]
E: getMenuItem: FIXME: could not find menu "C&ountries"
Program received signal SIGSEGV, Segmentation fault.
create_fl_digi_main_primary () at dialogs/fl_digi.cxx:4635
4635 getMenuItem(COUNTRIES_MLABEL)->hide();
(gdb) bt
#0 create_fl_digi_main_primary () at dialogs/fl_digi.cxx:4635
#1 0x080b91bd in create_fl_digi_main (argc=1, argv=0xbffff434)
at dialogs/fl_digi.cxx:5162
#2 0x08059458 in main (argc=1, argv=0xbffff434) at main.cxx:285
These compile errors look related. Possibly a bug where fldigi isn't 64 bit clean. CXX fldigi-fl_digi.o dialogs/fl_digi.cxx: In function ‘void create_fl_digi_main_primary()’: dialogs/fl_digi.cxx:4253:57: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] dialogs/fl_digi.cxx:4432:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] I tried the 32 bit version of fldigi and get the same crash. Could've known if I had read comment #0 more carefully :) Upstream is aware of the problem and working to fix it. This issue also surfaces in fldigi-3.21.9 (10?). There are threads on the fldigi-devel mailing list[1] about this issue. 1) https://lists.berlios.de/pipermail/fldigi-devel/2011-June/000649.html fldigi-3.21.10-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fldigi-3.21.10-3.fc15 (In reply to comment #5) > fldigi-3.21.10-3.fc15 has been submitted as an update for Fedora 15. > https://admin.fedoraproject.org/updates/fldigi-3.21.10-3.fc15 This update may or may not fix the issue. Please try it and report any problems. Thanks. Randy N3LRX It doesn't. Upstream 3.21.11 beta is still broken, too. W1HKJ sent me an updated src/dialogs/fl_digi.cxx file to test. That one still shows the bug, too... Strangely enough, his pre-built binary does work. Package fldigi-3.21.10-3.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fldigi-3.21.10-3.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/fldigi-3.21.10-3.fc15 then log in and leave karma (feedback). I just tested fldigi-3.21.10-3.fc15 and can confirm it is still broken. Upstream fldigi 3.21.11 works when compiled on Fedora 15, but only when it is compiled with --disable-nls (disables i18n). Building fldigi on Fedora with --disable-nls may be a good stop-gap measure until the bug is fixed upstream. fldigi-3.21.11-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fldigi-3.21.11-2.fc15 Created attachment 504283 [details]
patch to fix fldigi crash
Kamal Mostafa created a patch that fixes the fldigi crash:
Small patch (attached) fixes the problem.
In a nutshell, the 'menu_' array in dialogs/fl_digi.cxx gets prematurely
terminated, because 'mode_info[MODE_ANALYSIS].name' ends up as an empty
string in the menu_ table. That happens because the 'mode_info' array
in globals/globals.cxx uses an internationalized string to fill that
value _("Freq Analysis"). Something about the internationalization
runtime string juggling breaks down, leaving menu_ broken.
Simply using a regular string for "Freq Analysis" fixes all the damage.
For the record, I do not understand why this problem is only manifesting
now, however that fix seems easy and appropriate.
I'll apply this to fldigi 3.21.10 in Debian unstable. Dave, if you
would be so kind, please apply it to your main tree as well.
73 de KA6MAL
-Kamal
With luck the patch will be in fldigi upstream soon.
fldigi-3.21.11-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fldigi-3.21.11-5.fc15 Package fldigi-3.21.11-2.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fldigi-3.21.11-2.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/fldigi-3.21.11-2.fc15 then log in and leave karma (feedback). This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. fldigi-3.21.11-5.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. fldigi-3.21.14-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fldigi-3.21.14-1.fc15 fldigi-3.21.35-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fldigi-3.21.35-1.fc15 fldigi-3.21.35-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |