Bug 708772

Summary: VDSM: "a password is required to run sudo"
Product: Red Hat Enterprise Linux 6 Reporter: Dafna Ron <dron>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED INSUFFICIENT_DATA QA Contact: yeylon <yeylon>
Severity: medium Docs Contact:
Priority: low    
Version: 6.2CC: abaron, bazulay, iheim, srevivo, ykaul
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-30 18:54:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
logs none

Description Dafna Ron 2011-05-29 13:36:11 UTC
Created attachment 501602 [details]
logs

Description of problem:

umount failed during create of master SD:

Thread-542::DEBUG::2011-05-29 14:52:54,851::fileUtils::112::Storage.Misc.excCmd::(umount) FAILED: <err> = 'sudo: sorry, a password is required to run sudo\n'; <rc> = 1

Version-Release number of selected component (if applicable):

vdsm-4.9-70.el6.x86_64
libvirt-0.8.7-18.el6.x86_64

How reproducible:



Steps to Reproduce:
1. create master SD and fail umount
2.
3.
  
Actual results:

MainThread::WARNING::2011-05-29 11:42:11,208::blockSD::859::Storage.StorageDomain::(doUnmountMaster) Unmount failed because of errors that fuser can't solve
MainThread::DEBUG::2011-05-29 11:42:11,209::fileUtils::109::Storage.Misc.excCmd::(umount) '/usr/bin/sudo -n /bin/umount -f /rhev/data-center/mnt/blockSD/6f747221-9351-4fc5-87b6-9294257b7c0b/master' (cwd None)
MainThread::DEBUG::2011-05-29 11:42:11,220::fileUtils::109::Storage.Misc.excCmd::(umount) FAILED: <err> = 'sudo: sorry, a password is required to run sudo\n'; <rc> = 1
MainThread::ERROR::2011-05-29 11:42:11,221::misc::137::Storage.Misc::(panic) Panic: unmount /rhev/data-center/mnt/blockSD/6f747221-9351-4fc5-87b6-9294257b7c0b/master failed - Error unmounting master storage domain: 'masterdir=/rhev/data-center/mnt/blockSD/6f747221-9351-4fc5-87b6-9294257b7c0b/master, rc=1'
MainThread::ERROR::2011-05-29 11:42:11,223::misc::138::Storage.Misc::(panic) Traceback (most recent call last):
  File "/usr/share/vdsm/storage/spm.py", line 203, in __cleanupMasterMount
    blockSD.BlockStorageDomain.doUnmountMaster(master)
  File "/usr/share/vdsm/storage/blockSD.py", line 886, in doUnmountMaster
    raise se.StorageDomainMasterUnmountError(masterdir, rc)
StorageDomainMasterUnmountError: Error unmounting master storage domain: 'masterdir=/rhev/data-center/mnt/blockSD/6f747221-9351-4fc5-87b6-9294257b7c0b/master, rc=1'



Expected results:


Additional info: full logs

Thread-542::DEBUG::2011-05-29 14:52:54,851::fileUtils::112::Storage.Misc.excCmd::(umount) FAILED: <err> = 'sudo: sorry, a password is required to run sudo\n'; <rc> = 1
Thread-542::ERROR::2011-05-29 14:52:54,852::sp::344::Storage.StoragePool::(create) Create domain canceled due to an unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/sp.py", line 327, in create
    self.createMaster(poolName, msd, masterVersion, safeLease)
  File "/usr/share/vdsm/storage/sp.py", line 500, in createMaster
    domain.unmountMaster()
  File "/usr/share/vdsm/storage/blockSD.py", line 893, in unmountMaster
    self.doUnmountMaster(masterdir)
  File "/usr/share/vdsm/storage/blockSD.py", line 886, in doUnmountMaster
    raise se.StorageDomainMasterUnmountError(masterdir, rc)
StorageDomainMasterUnmountError: Error unmounting master storage domain: 'masterdir=/rhev/data-center/mnt/blockSD/e6cae5cc-65fa-411c-a7f7-27f600e13da0/master, rc=1'
Thread-542::INFO::2011-05-29 14:52:54,868::sp::743::Storage.StoragePool::(detachSD) sdUUID=<storage.blockSD.BlockStorageDomain instance at 0x7ff23c238fc8> spUUID=bb0c60f3-0df2-4
305-a81e-e0df186bfab7 msdUUID=e6cae5cc-65fa-411c-a7f7-27f600e13da0

Comment 3 Dan Kenigsberg 2011-05-29 15:19:11 UTC
afaict umount is listed in vdsm's sudoers file. Could it be that you are using an out-of date sudo (<1.7.3)? what do you have in `tail /etc/sudoers` ?

Comment 4 Dafna Ron 2011-05-29 15:52:47 UTC
there was nothing wrong with the sudo. there was something wrong with the umount. I rebooted the host and it solved the umount problem. 
probably an earlier test that did something to the umount. 

[root@blond-vdsf ~]# tail /etc/sudoers

## Allows members of the users group to mount and unmount the 
## cdrom as root
# %users  ALL=/sbin/mount /mnt/cdrom, /sbin/umount /mnt/cdrom

## Allows members of the users group to shutdown this system
# %users  localhost=/sbin/shutdown -h now

## Read drop-in files from /etc/sudoers.d (the # here does not mean a comment)
#includedir /etc/sudoers.d
[root@blond-vdsf ~]#

Comment 5 Dan Kenigsberg 2011-05-29 16:23:12 UTC
Please close if it cannot be reproduced.