Bug 708838

Summary: glines board doesn't refresh
Product: [Fedora] Fedora Reporter: Ben Asselstine <benasselstine>
Component: gnome-gamesAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 15CC: rstrode
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-20 19:57:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
white boxes remaining behind after glines moves
none
only show white box outlines when we're supposed to show them none

Description Ben Asselstine 2011-05-29 20:04:26 UTC
Created attachment 501651 [details]
white boxes remaining behind after glines moves

Description of problem:

Five Or More leaves box-outlines behind after a move.  

Version-Release number of selected component (if applicable):

3.0.1.1

How reproducible:
Easily reproduced.  It happens 100% of the time.

Steps to Reproduce:
1. Start a new game.
2. Click a ball with the mouse.
3. Click on an empty destination square with the mouse.
  
Actual results:
The ball moves to the destination square, and a white box appears around the destination square.

Expected results:
The ball moves to the destination square.

The white box shouldn't be shown at all.  In previous versions the white box was used only when keyboard arrow-keys+enter were used.

Additional info:

The board gets redrawn when a line is completed, so some of the white boxes go away.

I have fast moves turned on, and a non-standard background colour set in preferences.

I have attached a video of the bug in action.

Comment 1 Ben Asselstine 2011-07-17 14:31:22 UTC
Created attachment 513525 [details]
only show white box outlines when we're supposed to show them

Comment 2 Ben Asselstine 2011-07-17 14:40:41 UTC
The white boxes that can sometimes outline a square get enabled when the arrow keys are used, and they go away when the mouse is used to click a ball.

The preceding patch fixes the problem of many white boxes hanging around.
It also fixes the problem of white boxes showing up when I click on a ball.  

I haven't done the bug-research to find out why the white boxes suddenly showed up when using a mouse, so fixing this may cause a regression for somebody else.

Please commit this patch.

Comment 3 Ben Asselstine 2011-07-20 19:57:59 UTC
Fixed upstream at:
https://bugzilla.gnome.org/show_bug.cgi?id=651870