| Summary: | Review Request: jackctlmmc - control JACK transport via MIDI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brendan Jones <brendan.jones.it> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 15 | CC: | fedora-package-review, martin.gieseking, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | jackctlmmc-4-3.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-26 18:54:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Brendan Jones
2011-05-31 00:26:42 UTC
Here is my review for this package * rpmlint says qjackmmc.x86_64: E: description-line-too-long C QJackMMC is a Qt based program that can connect to a device or program that emits qjackmmc.x86_64: E: description-line-too-long C MIDI Machine Control (MMC) and allow it to drive JACK transport, which in turn can The limit is 80 columns, so you will need to trim a word or two. qjackmmc.x86_64: W: no-documentation qjackmmc.x86_64: W: no-manual-page-for-binary qjackmmc jackctlmmc.x86_64: W: no-manual-page-for-binary qjackmmc jackctlmmc.x86_64: W: no-manual-page-for-binary jackctlmmc These can be ignored since the upstream doesn't ship anything relevant. * main.c and common.* seem to be GPLv2 instead of GPLv2+. So the main package needs to be GPLv2. In contrast, the code in qt/* is GPLv2+, so the qt subpackage is GPLv2+. I wonder if the upstream really intended it to be this way. ? Why does the subpackage qjackmmc require the main package? * The %files section seems messed up. qjackmmc's contents are also listed in the main package's %files section. * sed -e 's|\;MIDI|\;X-Midi|g' -e 's|\;JACK|\;X-JACK|g' -e 's|\;ALSA|\;X-ALSA|g' This should better be sed -e 's|\;MIDI|\;Midi|g' -e 's|\;JACK|\;X-Jack|g' -e 's|\;ALSA|\;X-Alsa|g' for consistency with other packages, and especially the multimedia-menus package. * The desktop file should be installed via desktop-file-install in the %install section. Please see http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files (In reply to comment #1) > * sed -e 's|\;MIDI|\;X-Midi|g' -e 's|\;JACK|\;X-JACK|g' -e > 's|\;ALSA|\;X-ALSA|g' > This should better be > sed -e 's|\;MIDI|\;Midi|g' -e 's|\;JACK|\;X-Jack|g' -e > 's|\;ALSA|\;X-Alsa|g' > for consistency with other packages, and especially the multimedia-menus > package. > > * The desktop file should be installed via desktop-file-install in the %install > section. Please see > http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Just for clarification, the above two issues can be resolved by a single desktop-file-install command at the end of %install section by using --add-category and --remove-category, etc. See $ desktop-file-install --help-all Thanks for the review Orcan. No issue with any of your catches. Will post an update as soon as upstream gets back to me regarding the license. Hi Orcan, is this a blocker? I am still waiting on the maintainer to get back to me. Alternatively, I could package it as one package instead of separate ones? 192-168-1-150:~/workspace/settings$ rpmlint /home/brendan/rpmbuild/RPMS/i686/*jackctl*.rpm jackctlmmc.i686: W: no-manual-page-for-binary jackctlmmc 2 packages and 0 specfiles checked; 0 errors, 1 warnings. 192-168-1-150:~/workspace/settings$ rpmlint /home/brendan/rpmbuild/SRPMS/*jackctl*.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 192-168-1-150:~/workspace/settings$ Other issues have been updated here: SPEC: http://bsjones.fedorapeople.org/jackctlmmc.spec SRPM: http://bsjones.fedorapeople.org/jackctlmmc-4-2.fc15.src.rpm Hi Brendan, I would keep the programs packaged separately because some users who are interested in jackctlmmc possibly don't like the whole Qt stuff to be installed by default. As long as the license isn't updated, just change the License field of the base package to GPLv2 and that of the subpackage to GPLv2+. Also add the license file qt/COPYING to the subpackage. Just as Martin summarized; it is not really a blocker, but we need, at the very least, to match the license the tarball tells us. OK - updated as suggested - thanks guys. SPEC: http://bsjones.fedorapeople.org/jackctlmmc.spec SRPM: http://bsjones.fedorapeople.org/jackctlmmc-4-3.fc17.src.rpm Thanks Brendan, this is good to go --------------------------------------------- This package (jackctlmmc) is APPROVED by oget --------------------------------------------- Brendan, Martin, could you guys take a look at this review request if/when you get time? bug# 728737 ? Thanks! New Package SCM Request ======================= Package Name: jackctlmmc Short Description: Allows control over JACK transport via Midi Owners: bsjones Branches: f14 f15 f16 InitialCC: Git done (by process-git-requests). jackctlmmc-4-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/jackctlmmc-4-3.fc16 jackctlmmc-4-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/jackctlmmc-4-3.fc15 jackctlmmc-4-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/jackctlmmc-4-3.fc14 jackctlmmc-4-3.fc16 has been pushed to the Fedora 16 testing repository. jackctlmmc-4-3.fc15 has been pushed to the Fedora 15 stable repository. jackctlmmc-4-3.fc14 has been pushed to the Fedora 14 stable repository. jackctlmmc-4-3.fc16 has been pushed to the Fedora 16 stable repository. |