Bug 709622

Summary: Non-portable "while" loop form used
Product: Red Hat Enterprise Linux 5 Reporter: Denys Vlasenko <dvlasenk>
Component: kexec-toolsAssignee: Cong Wang <amwang>
Status: CLOSED ERRATA QA Contact: WANG Chao <chaowang>
Severity: low Docs Contact:
Priority: unspecified    
Version: 5.8CC: ccui, czhang, phan, rkhan, ruyang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kexec-tools-1_102pre-134_el5 Doc Type: Bug Fix
Doc Text:
No description necessary
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-21 03:18:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Denys Vlasenko 2011-06-01 08:42:52 UTC
mkdumprd script contains this fragment:

            echo "deleting routers"
            while route del default gw 0.0.0.0 dev \$interface 2>/dev/null ; do
            done

This won't work in bash, bash requires at least one command in while loop body.
The fix might be:

            echo "deleting routers"
            while route del default gw 0.0.0.0 dev \$interface 2>/dev/null ; do
                :
            done

This is not an urgent problem since busybox shell does accept current form, but for compatibility with other shells it's better to change the script to be bash-compatible.

Comment 1 Cong Wang 2011-06-08 06:56:07 UTC
I did the same change for RHEL6, will change this for RHEL5 too.

Comment 5 Cong Wang 2012-01-21 07:07:03 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No description necessary

Comment 6 errata-xmlrpc 2012-02-21 03:18:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0152.html