Bug 709649

Summary: fails to build without upstream patches
Product: Red Hat Enterprise Linux 6 Reporter: Kamil Dudka <kdudka>
Component: matahariAssignee: Adam Stokes <astokes>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 6.1CC: abeekhof, akarol, apevec, ddumas, matahari-maint, ovasik, rbryant
Target Milestone: rcKeywords: EasyFix, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: matahari-0.4.2-2.el6 Doc Type: Bug Fix
Doc Text:
No description needed
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 11:39:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
proposed fix none

Description Kamil Dudka 2011-06-01 09:57:01 UTC
Version-Release number of selected component (if applicable):
matahari-0.4.0-5.el6


Steps to Reproduce:
1. rpmbuild --define '__patch /bin/true' --rebuild matahari-0.4.0-5.el6.src.rpm

  
Actual results:
-- checking for module 'glib-2.0'
--   found glib-2.0, version 2.26.0
-- checking for module 'libpcre'
--   found libpcre, version 8.10
-- Found QMF: /usr/lib64/libqmf.so
-- Found QPIDCLIENT: /usr/lib64/libqpidclient.so
-- Found QPIDCOMMON: /usr/lib64/libqpidcommon.so
-- Found QPIDTYPES: /usr/lib64/libqpidtypes.so
CMake Error at src/cmake/modules/FindQPID.cmake:107 (message):
  Could not determine Qpid version, probably QPIDD not installed
Call Stack (most recent call first):
  src/CMakeLists.txt:143 (find_package)


-- Configuring incomplete, errors occurred!
error: Bad exit status from /var/tmp/rpm-tmp.YgQjAL (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.YgQjAL (%build)


Additional info:
The proposed change is required for Coverity to scan defects in downstream
patches separately.

Comment 1 Kamil Dudka 2011-06-01 09:58:13 UTC
Created attachment 502206 [details]
proposed fix

Comment 3 Andrew Beekhof 2011-06-10 01:26:06 UTC
We are upstream.  As such, there are no downstream patches for matahari.  All patches are backports from upstream, where backport in this case is generally "git diff $tarball_version HEAD".

Comment 4 Ondrej Vasik 2011-06-10 08:16:46 UTC
I understand, but if these scans should be done fully automatically (and that's our plan), we can't differentiate between packages where patches are just backports from upstream and between packages where we have downstream patches. That's the reason for the bug report.

Comment 6 Andrew Beekhof 2011-06-17 07:11:40 UTC
Matahari is still a tech-preview component.  Builds/scans of unpatched versions are of no interest/value as they bare little resemblance to the shipping code. Particularly as we also do our own coverity scanning.

This will instead be fixed as a side effect of a rebase in the lead-up to 6.2

Comment 12 Russell Bryant 2011-11-16 21:13:53 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No description needed

Comment 13 errata-xmlrpc 2011-12-06 11:39:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1569.html