Bug 710041
Summary: | Condormatic - job_name with slashes | ||
---|---|---|---|
Product: | [Retired] CloudForms Cloud Engine | Reporter: | Jiri Tomasek <jtomasek> |
Component: | aeolus-conductor | Assignee: | Jan Provaznik <jprovazn> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | wes hayutin <whayutin> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 0.3.1 | CC: | akarol, dajohnso, deltacloud-maint, jprovazn, morazi, ssachdev |
Target Milestone: | alpha | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | Type: | --- | |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jiri Tomasek
2011-06-02 10:30:46 UTC
moving bugs to cloud engine project this fixes commit e33a3e90b917b62e11b80d6d5ac23aca486284d9 Should this be ON_QA? moving to on_qa Slashed replaced. #vi /usr/share/aeolus-conductor/app/util/condormatic.rb def write_pw_file(job_name, pw) # here we write out the password file # FIXME: should this be configurable? pwdir = '/var/lib/aeolus-conductor/jobs' FileUtils.mkdir_p(pwdir, options={:mode => 0700}) FileUtils.chown('aeolus', 'aeolus', pwdir) # Restrict job names to relatively sane characters only job_name.gsub!(/[^a-zA-Z0-9\.\-]/, '_') pwfilename = File.join(pwdir, job_name) tmpfile = Tempfile.new(job_name, pwdir) tmpfilename = tmpfile.path tmpfile.write(pw) tmpfile.close File.rename(tmpfilename, pwfilename) return pwfilename end [root@dell-pe860-01 lib]# rpm -qa | grep aeolus aeolus-conductor-0.3.0-0.el6.20110701204941gitd66e27c.noarch aeolus-all-0.3.0-0.el6.20110701204941gitd66e27c.noarch aeolus-conductor-doc-0.3.0-0.el6.20110701204941gitd66e27c.noarch aeolus-conductor-daemons-0.3.0-0.el6.20110701204941gitd66e27c.noarch aeolus-configure-2.0.1-0.el6.20110628141215gitb8aaf85.noarch rubygem-aeolus-cli-0.0.1-1.el6.20110701204941gitd66e27c.noarc need a description on how qa might test this w/o just looking at the code. (In reply to comment #6) > need a description on how qa might test this w/o just looking at the code. Slash is used when creating an instance name when launching a deployment. Sufficient test is checking if it's possible to launch a deployment - if there is still this bug, deployment launch fail, if you get running instance, it's fixed. There should also be new file in /var/lib/aeolus-conductor/jobs/ with name "job_#{deployment_name}_#{instance_name}_#{number}" Processing DeploymentsController#create (for 10.11.9.126 at 2011-07-11 19:39:21) [POST] Parameters: {"commit"=>"Launch", "action"=>"create", "controller"=>"deployments", "deployment"=>{"name"=>"test02", "frontend_realm_id"=>"2", "deployab le_xml"=>"<deployable name=\"vmwareWesTest02\">\r\n<description>test01</description>\r\n<assemblies>\r\n<assembly name=\"frontend01\" hwp=\"vmware-mediu m\">\r\n<image id=\"d2bba849-7af0-4dbd-a53a-44f6f39cc9d7\" build=\"52308cba-7dd6-4cb0-b11c-367d95274134\">\r\n</image>\r\n</assembly>\r\n</assemblies>\r \n</deployable>\r\n", "pool_id"=>"1"}} universe = grid executable = job_test02_frontend01_5 grid_resource = deltacloud http://sgi-xe310-02.rhts.eng.bos.redhat.com:3006/api DeltacloudUsername = Administrator DeltacloudPasswordFile = /var/lib/aeolus-conductor/jobs/job_test02_frontend01_5 DeltacloudImageId = factory-image-4d4f8300-0e7d-48e4-9a01-feec8178a6ad DeltacloudHardwareProfile = large DeltacloudHardwareProfileMemory = 1024.0 DeltacloudHardwareProfileCPU = 2.0 DeltacloudHardwareProfileStorage = DeltacloudKeyname = DeltacloudPoolFamily = 1 requirements = true notification = never queue $? (return value?) is 0 Redirected to https://ibm-x3650-05.ovirt.rhts.eng.bos.redhat.com/conductor/deployments/5 Completed in 773ms (DB: 39) | 302 Found [https://ibm-x3650-05.ovirt.rhts.eng.bos.redhat.com/conductor/deployments] Processing DeploymentsController#show (for 10.11.9.126 at 2011-07-11 19:39:22) [GET] Parameters: {"action"=>"show", "id"=>"5", "controller"=>"deployments"} Rendering template within layouts/application Rendering deployments/show : -- Submitter: ibm-x3650-05.ovirt.rhts.eng.bos.redhat.com : <172.17.95.96:52579> : ibm-x3650-05.ovirt.rhts.eng.bos.redhat.com ID OWNER SUBMITTED RUN_TIME ST PRI SIZE CMD 1.0 aeolus 7/11 17:24 0+00:00:00 H 0 0.0 job_zdfg_frontend_ 2.0 aeolus 7/11 18:09 0+15:27:25 R 0 0.0 job_vmwareTools01_ 3.0 aeolus 7/11 19:39 0+13:57:11 R 0 0.0 job_test02_fronten 3 jobs; 0 idle, 2 running, 1 held [root@ibm-x3650-05 32fdc5cdf3f181e7b6987410cf607d15]# [root@ibm-x3650-05 32fdc5cdf3f181e7b6987410cf607d15]# rpm -qa |grep aeolus aeolus-all-0.3.0-0.el6.20110711131044git5bc7abf.noarch aeolus-configure-2.0.1-0.el6.20110708134115gitab1e6dc.noarch aeolus-conductor-0.3.0-0.el6.20110711131044git5bc7abf.noarch aeolus-conductor-daemons-0.3.0-0.el6.20110711131044git5bc7abf.noarch rubygem-aeolus-cli-0.0.1-1.el6.20110711131044git5bc7abf.noarch aeolus-conductor-doc-0.3.0-0.el6.20110711131044git5bc7abf.noarch [root@ibm-x3650-05 32fdc5cdf3f181e7b6987410cf607d15]# release pending... release pending... release pending.. 2 closing out old bugs perm close |