Bug 710115

Please note that this package is needed by the latest Scilab version, see bug 472639 .

I'll do this review.

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
jlatexmath.noarch: W: incoherent-version-in-changelog 0.9.6 ['0.9.6-1.fc15', '0.9.6-1']
Please fix.
jlatexmath-fop.noarch: W: no-documentation
Not a problem.
jlatexmath-fop.noarch: W: class-path-in-manifest /usr/share/java/jlatexmath-fop.jar
Please fix.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: GPLv2+
[!]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
Please install the LICENSE and COPYING files.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[-]  Sources used to build the package matches the upstream source, as provided in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[-]  If package contains pom.xml files install it (including depmaps) even when building with ant
[-]  pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly)

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.


=== Issues ===
1. Rpmlint issues.
2. Not installed License/copying files

Spec URL: http://davidclement8298.perso.neuf.fr/jlatexmath.spec
SRPM URL: http://davidclement8298.perso.neuf.fr/jlatexmath-0.9.6-2.fc14.src.rpm
Patch0 URL: http://davidclement8298.perso.neuf.fr/0001-incorrect-fsf-address.patch

Thanks for the review, updated :
  - Use sed on the spec file to fix class-path-in-manifest
  - Fixed incoherent-version-in-changelog
  - Add patch to fix fsf address

It pass rpmlint with 3 warnings fixed by comments :

jlatexmath.src:11: W: macro-in-comment %{name}
jlatexmath.src:11: W: macro-in-comment %{version}
jlatexmath.src: W: invalid-url Source0: jlatexmath-src-all-0.9.6.zip

Looks good.

APPROVED.

Let me know of you FAS name and I'll sponsor you.

Ping, what is your FAS name?

Sorry for the delay, I just send my introduction on the devel ML. My FAS name is davidcl [http://koji.fedoraproject.org/koji/userinfo?userID=1793].

Sponsored.

New Package SCM Request
=======================
Package Name: jlatexmath
Short Description: Java API to display mathematical formulas written in LaTeX
Owners: davidcl
Branches: f14 f15 el4 el5 el6
InitialCC:

Git done (by process-git-requests).

jlatexmath-0.9.6-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/jlatexmath-0.9.6-2.fc15

jlatexmath-0.9.6-2.fc15 has been pushed to the Fedora 15 testing repository.

jlatexmath-0.9.6-2.fc15 has been pushed to the Fedora 15 stable repository.