Bug 710392

Summary: OfflineLog is removed from spool directory
Product: Red Hat Enterprise MRG Reporter: Luigi Toscano <ltoscano>
Component: condor-wallaby-base-dbAssignee: Robert Rati <rrati>
Status: CLOSED ERRATA QA Contact: Luigi Toscano <ltoscano>
Severity: urgent Docs Contact:
Priority: urgent    
Version: DevelopmentCC: iboverma, matt, tstclair
Target Milestone: 2.0   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: condor-wallaby-base-db-1.13-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-27 14:11:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 674161    

Description Luigi Toscano 2011-06-03 10:08:18 UTC 
Description of problem:
When green scheduling is configured using wallaby, OfflineLog file is removed from spool (by condor_preen). This is due to a bug in the check_spool_dir() function (src/condor_preen) which seems to compare files in the spool directory according to the basename, while the file name added to VALID_SPOOL_FILES in wallaby uses the full path.

Possible solutions:
- (quick) fix the default wallaby db to use the basename of the file (and maybe fix the documentation for all the features which needs to change VALID_SPOOL_FILES and state that only file in the spool directory are considered and the relative path - i.e. only the file name - must be used)
- (not-so-quick) fix the code to compare according to the real path (this solution needs more analysis as it could break few assumptions).

Version-Release number of selected component (if applicable):
condor-7.6.1-0.8 (but probably also older version)
Comment 1 Matthew Farrellee 2011-06-03 14:15:30 UTC 
This is a DB fix, but the V7_6-branch VALID_SPOOL_FILES default also needs to be changed to include OfflineLog.
Comment 2 Timothy St. Clair 2011-06-03 16:25:39 UTC 
updated upstream: 
https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=2209
Comment 3 Robert Rati 2011-06-03 17:17:28 UTC 
The value for VALID_POOL_FILES on the PowerManagementCollector feature is now:
VALID_SPOOL_FILES: $(VALID_SPOOL_FILES), OfflineLog

Fixed on master
Comment 5 Luigi Toscano 2011-06-08 15:54:28 UTC 
The  (quick) fix has been applied (see comment 3). Verified on 
condor-wallaby-base-db-1.13-1 (noarch package).