Bug 710517
| Summary: | Review Request: gnome-shell-extension-remove-accessibility-icon - A gnome-shell extension for removing the accessibility icon | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Clint Savage <herlo1> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, gwync, herlo1, jereman_gnr, notting, spider |
| Target Milestone: | --- | Flags: | herlo1:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-15 05:49:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2011-06-03 15:25:10 UTC
Licensing issue seems to be the only hold-up. Builds just fine in mock. $ rpmlint rpmbuild/SPECS/gnome-shell-extension-remove-accessibility-icon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. spec file looks clean $ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-shell-extension-remove-accessibility-icon-20110529-1.fc15.noarch.rpm gnome-shell-extension-remove-accessibility-icon.noarch: W: invalid-license GPL gnome-shell-extension-remove-accessibility-icon.noarch: W: no-documentation SHOULD at least include a README and/or manual page. Just update here when the licensing is sorted and I'll do another review. Cheers, Clint Thanks for your help, Clint. (In reply to comment #1) > Licensing issue seems to be the only hold-up. License is BSD. Upstream added licensing information to the source. > SHOULD at least include a README and/or manual page. Upstream added a COPYING and a README file. * Sat Jun 04 2011 Fabian Affolter <fabian> - 20110603-1 - README and COPYING added - License is Modified BSD License Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-remove-accessibility-icon.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15.src.rpm $ rpmlint /tmp/gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/SPECS/gnome-shell-extension-remove-accessibility-icon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. License stated as BSD in COPYING, good to go. Package approved. Clint New Package VCS Request ======================= Package Name: gnome-shell-extension-remove-accessibility-icon Short Description: A gnome-shell extension for removing the accessibility icon Owners: fab Branches: F15 InitialCC: The one thing I have to say against this is that it removes the accessibility icon for all users without a chance to restore it, which is a bit of a bummer in a shared environment. But for a home user, that shouldn't be an issue. New Package SCM Request ======================= Package Name: gnome-shell-extension-remove-accessibility-icon Short Description: A gnome-shell extension for removing the accessibility icon Owners: fab Branches: f15 InitialCC: Git done (by process-git-requests). gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 has been pushed to the Fedora 15 testing repository. gnome-shell-extension-remove-accessibility-icon-20110603-1.fc15 has been pushed to the Fedora 15 stable repository. yum search returns the following short description "gnome-shell-extension-remove-accessibility-icon.noarch : A gnome-shell extensions for removing the accessibility icon" extensions should be changed to extension. not working in fedora 16 beta, it crashes gnome shell |