Bug 710996
| Summary: | Network manager has crashed when wifi connects to a WPA2/PEAP/MSCHAPv2 network | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | kurik | ||||
| Component: | kde-plasma-networkmanagement | Assignee: | Rex Dieter <rdieter> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 15 | CC: | collura, dcbw, kevin, ltinkl, rdieter | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | kde-plasma-networkmanagement-0.9-0.53.20110616git.nm09.fc15 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-06-30 18:58:49 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
kurik
2011-06-06 07:02:15 UTC
This crashes in this loop:
foreach (InterfaceItem* ifaceitem, m_interfaces) {
Solid::Control::NetworkInterface* iface = ifaceitem->interface();
if (iface->type() == Solid::Control::NetworkInterface::Ieee80211) {
//kDebug() << "there's a wifi iface" << ifaceitem->connectionName() << iface->interfaceName();
m_hasWirelessInterface = true; // at least one interface is wireless. We're happy.
m_wifiCheckBox->show();
break;
}
}
on this line:
if (iface->type() == Solid::Control::NetworkInterface::Ieee80211) {
I assume iface is NULL, adding a NULL check, i.e.:
if (iface && iface->type() == Solid::Control::NetworkInterface::Ieee80211) {
should probably fix it.
In fact, this has been fixed upstream on April 19: https://projects.kde.org/projects/extragear/base/networkmanagement/repository/revisions/ff9076fe85f31b0cfa388d92a0c6d288ad07f396/diff/applet/nmpopup.cpp (but we're stuck with the March 23 snapshot for the moment). Backporting the 2 added NULL checks from that commit is rather easy, I can do that tomorrow if nobody beats me to it. kde-plasma-networkmanagement-0.9-0.47.20110323.fc15.1 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kde-plasma-networkmanagement-0.9-0.47.20110323.fc15.1 kde-plasma-networkmanagement-0.9-0.40.20110323.fc14.1 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kde-plasma-networkmanagement-0.9-0.40.20110323.fc14.1 kde-plasma-networkmanagement-0.9-0.40.20110323.fc13.1 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kde-plasma-networkmanagement-0.9-0.40.20110323.fc13.1 Package kde-plasma-networkmanagement-0.9-0.47.20110323.fc15.1: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kde-plasma-networkmanagement-0.9-0.47.20110323.fc15.1' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/kde-plasma-networkmanagement-0.9-0.47.20110323.fc15.1 then log in and leave karma (feedback). Does the above update fix your crashes? Unfortunately not. I have tested the new RPM immediately once become available, but the problem persists. The symptoms are exactly the same. I am currently trying to investigate the place in code causing the issue to be able, at least, provide more info. Have you restarted your session after upgrading? Does the problem persist after a session restart? If so, we need a new backtrace. (I strongly doubt the backtrace is the same, as I fixed that exact place of code.) Created attachment 504809 [details]
Backtrace from 2011-06-15
OK, the back-trace is attached: https://bugzilla.redhat.com/attachment.cgi?id=504809 Regarding the restart of the session: yes the computer has been restarted several times since I have installed the new network manager RPM and the problem is still the same. #6 0x0000003160e71fa0 in QRegion::shared_empty () from /usr/lib64/libQtGui.so.4 #7 0x00007f9dfcac71ab in NMPopup::updateHasWireless (this=0x16e9450) at /usr/src/debug/networkmanagement-0.9/applet/nmpopup.cpp:536 Huh? There's nothing at nmpopup.cpp:536 which would call QRegion::shared_empty. I guess the iface pointer is completely bogus here (not valid, but also not NULL) and has a bad vtable, so we end up calling QRegion::shared_empty instead of Solid::Control::NetworkInterface::type. But I'm not sure how to fix that. I wonder if we shouldn't give up trying to fix that in the old snapshot and move on to the current nm09 branch snapshots instead. Is there a way how to upgrade my current Fedora-15 to use nm09 ? According to guys from KDE team, this problem should be fixed (reworked) somehow in the mn09 version. Configure the kde-redhat kde.repo, then use: yum --enablerepo=kde-unstable update kde-plasma-networkmanagement The snapshots are due to move to kde-testing, updates-testing and then updates soon. Fixing this problem in the existing 20110323 snapshot would probably require a Valgrind log to see what exactly is going wrong. (At this point, I guess it's a use-after-free bug.) That said, I'm not sure this is fixed in the current snapshots either. Upstream added the NULL checks I backported, but NULL checks don't help against invalid non-NULL pointers. I'm reopening the bug. I have queued the updates with the added NULL checks for stable anyway, they cannot hurt, but I removed the reference to this bug, which appears not fixed (completely). See also, https://admin.fedoraproject.org/updates/kde-plasma-networkmanagement-0.9-0.53.20110616git.nm09.fc15 (pending, not queued... yet) kde-plasma-networkmanagement-0.9-0.53.20110616git.nm09.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kde-plasma-networkmanagement-0.9-0.53.20110616git.nm09.fc15 kde-plasma-networkmanagement-0.9-0.53.20110616git.nm09.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. Having installed the kde-plasma-networkmanagement-0.9-0.53.20110616git.nm09.fc15 package it works and seems to be stable (at least for me). Thanks guys. |