Bug 711350

Summary: Review Request: jboss-parent - JBoss Parent POM
Product: [Fedora] Fedora Reporter: Marek Goldmann <mgoldman>
Component: Package ReviewAssignee: Alexander Kurtakov <akurtako>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, fedora-package-review, notting, pingou, puntogil
Target Milestone: ---Flags: akurtako: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-28 13:32:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 726044, 726351    
Attachments:
Description Flags
jboss-parent.spec none

Comment 1 Marek Goldmann 2011-07-15 08:05:12 UTC
Version 6 was released - I'll update this spec file to reflect this soon.

Comment 2 gil cattaneo 2011-07-16 14:09:11 UTC
Created attachment 513487 [details]
jboss-parent.spec

Comment 3 gil cattaneo 2011-07-16 14:21:51 UTC
now it work

Comment 4 gil cattaneo 2011-07-16 14:24:33 UTC
the problem was here

install -d -m 755 $RPM_BUILD_ROOT%{_mavenpomdir}
install -pm 644 pom.xml $RPM_BUILD_ROOT%{_mavenpomdir}/JPP.jboss-%{name}.pom
%add_to_maven_depmap org.jboss %{name} %{version} JPP jboss/%{name}

modified in this way (thanks to alt linux) works

install -d -m 755 $RPM_BUILD_ROOT%{_mavenpomdir}
install -pm 644 pom.xml $RPM_BUILD_ROOT%{_mavenpomdir}/JPP-%{name}.pom
%add_to_maven_depmap org.jboss %{name} %{version} JPP %{name}

Comment 5 Marek Goldmann 2011-07-18 11:54:51 UTC
(In reply to comment #4)
> the problem was here

Submitted spec file follows Fedora guidelines and is buildable. Specified change is not necessary for Fedora, although it may be necessary for other distros like Mageia as we discussed it on IRC.

Comment 6 Marek Goldmann 2011-07-18 13:24:18 UTC
Updated files to version 6, using new %add_maven_depmap macro.

Spec URL:
http://goldmann.fedorapeople.org/package_review/jboss-parent/2/jboss-parent.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/jboss-parent/2/jboss-parent-6-1.fc16.src.rpm

Comment 7 Marek Goldmann 2011-07-22 11:20:43 UTC
And a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3222447

Comment 8 Alexander Kurtakov 2011-07-27 13:40:45 UTC
I would do this one.

Comment 9 Alexander Kurtakov 2011-07-27 13:58:04 UTC
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
jboss-parent.noarch: W: invalid-url URL: http://www.jboss.org/ HTTP Error 403: Forbidden
False positive.
./jboss-parent.spec: W: no-%build-section
Please add a build section with mvn-rpmbuild install in it. This will help not missing newly added dependencies in future versions because the build will fail this way.
./jboss-parent.spec: W: invalid-url Source0: jboss-parent-6.tar.xz
Generated one so it's fine.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: LGPLv2+
[-]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[-]  Sources used to build the package matches the upstream source, as provided in the spec URL.
[!]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
A lot of pacakges will need ot be added to Buildrequires but there was a shortcut for saying that all BuildRequries are requires or smth like this
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[-]  Javadoc documentation files are generated and included in -javadoc subpackage
[-]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[-]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[-]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[!]  Package DOES NOT use %update_maven_depmap in %post/%postun
[!]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.

=== Issues ===
1. Add a build section to let mvn check the dependencies.
2. Drop update_maven_depmap
3. Drop Requires(post|postun) on jpackage-utils
4. -n %{name}-%{version} can be omitted this is the default

Comment 11 Marek Goldmann 2011-07-28 11:31:30 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3235374

Comment 12 Alexander Kurtakov 2011-07-28 12:01:53 UTC
Looks good.
APPROVED

Comment 13 Marek Goldmann 2011-07-28 12:04:40 UTC
Thank you for review!

New Package SCM Request
=======================
Package Name:      jboss-parent
Short Description: JBoss Parent POM
Owners:            goldmann
Branches:          f16

Comment 14 Gwyn Ciesla 2011-07-28 12:37:49 UTC
Git done (by process-git-requests).

Comment 15 Marek Goldmann 2011-07-28 13:32:58 UTC
Thank you, closing.