Bug 711671

Summary:	Comma separated values for --runasexternalgroup option in sudorule-mod are accepted as a single value.
Product:	Red Hat Enterprise Linux 6	Reporter:	Gowrishankar Rajaiyan <grajaiya>
Component:	ipa	Assignee:	Rob Crittenden <rcritten>
Status:	CLOSED ERRATA	QA Contact:	Chandrasekar Kannan <ckannan>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.2	CC:	benl, dpal, jgalipea
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ipa-2.1.0-1.el6	Doc Type:	Bug Fix
Doc Text:	Cause: Comma-separated values are not handled properly when using sudorule-mod to manage runasexternaluser and runasexternalgroup Consequence: The wrong values are being stored in the entry. Fix: These options have been removed from the sudorule-mod command. Use sudorule-add-runasuser and sudurole-runasgroup instead. Result: --runasexternaluser and --runasexternalgroup have been deprecated.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 18:33:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gowrishankar Rajaiyan 2011-06-08 06:30:00 UTC

Description of problem:
When doing a modification using sudorule-mod, the whole string of comma
separated groups are accepted as a single value.

Version-Release number of selected component (if applicable):
ipa-server-2.0.0-25.el6.x86_64
ipa-admintools-2.0.0-25.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. ipa sudorule-add shanks-rule1
2. ipa sudorule-add-runasgroup shanks-rule1 --groups=test1,test2,test3,test4
3. ipa sudorule-find shanks-rule1 --all --raw
  dn: ipauniqueid=f7a20452-918c-11e0-9551-525400deab7b,cn=sudorules,cn=sudo,dc=lab,dc=eng,dc=pnq,dc=redhat,dc=com
  cn: shanks-rule1
  ipaenabledflag: TRUE
  ipasudorunasextgroup: test1
  ipasudorunasextgroup: test3
  ipasudorunasextgroup: test2
  ipasudorunasextgroup: test4
  ipauniqueid: f7a20452-918c-11e0-9551-525400deab7b
  objectclass: ipaassociation
  objectclass: ipasudorule
----------------------------
Number of entries returned 1
----------------------------

4. ipa sudorule-mod shanks-rule1 --runasexternalgroup=group1,group2,group3,group4

Actual results:
# ipa sudorule-find shanks-rule1 --all --raw
  dn: ipauniqueid=f7a20452-918c-11e0-9551-525400deab7b,cn=sudorules,cn=sudo,dc=lab,dc=eng,dc=pnq,dc=redhat,dc=com
  cn: shanks-rule1
  ipaenabledflag: TRUE
  ipasudorunasextgroup: group1,group2,group3,group4
  ipauniqueid: f7a20452-918c-11e0-9551-525400deab7b
  objectclass: ipaassociation
  objectclass: ipasudorule
----------------------------
Number of entries returned 1
----------------------------

Unable to mod multiple runas external groups using sudorule-mod.


Expected results:
Should allow to mod multiple runas external groups using sudorule-mod.

Additional info:

Comment 2 Rob Crittenden 2011-06-08 13:37:50 UTC

The core problem is likely the same as BZ 711667

https://fedorahosted.org/freeipa/ticket/1307

Comment 3 Rob Crittenden 2011-08-01 20:23:42 UTC

master: d8c479731e6f985f4c4be1e1e4fee858e9eae901

Comment 5 Rob Crittenden 2011-10-31 19:42:49 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: Comma-separated values are not handled properly when using sudorule-mod to manage runasexternaluser and runasexternalgroup
Consequence: The wrong values are being stored in the entry.
Fix: These options have been removed from the sudorule-mod command. Use sudorule-add-runasuser and sudurole-runasgroup instead.
Result: --runasexternaluser and --runasexternalgroup have been deprecated.

Comment 6 Gowrishankar Rajaiyan 2011-11-02 06:53:26 UTC

[root@jetfire ~]# ipa sudorule-add-runasgroup shanks-rule1 --groups=testg1,testg2,testg3,testg4
  Rule name: shanks-rule1
  Enabled: TRUE
  RunAs External Group: testg1, testg2, testg3, testg4
-------------------------
Number of members added 4
-------------------------


[root@jetfire ~]# ipa sudorule-mod shanks-rule1 --runasexternalgroup=group1,group2,group3,group4
ipa: ERROR: invalid 'runasexternalgroup': this option has been deprecated.
[root@jetfire ~]# 


This option has been deprecated.
Verified. Version: ipa-server-2.1.3-7.el6.x86_64ipa-server-2.1.3-7.el6.x86_64

Comment 7 errata-xmlrpc 2011-12-06 18:33:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1533.html