Bug 711852

Summary: second ASEHA agent wont start - Unique attribute collision
Product: Red Hat Enterprise Linux 6 Reporter: John Brier <jbrier>
Component: resource-agentsAssignee: Chris Feist <cfeist>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: high Docs Contact:
Priority: high    
Version: 6.2CC: agk, ccaulfie, cfeist, cluster-maint, djansa, emcnabb, fdinitto, jentrena, jkortus, lhh, rpeterso, syeghiay, teigland
Target Milestone: rcKeywords: OtherQA
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: resource-agents-3.9.2-7.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 12:05:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 748554    
Attachments:
Description Flags
Cluster.conf used to replicate bug and test fix
none
Patch to fix bz none

Description John Brier 2011-06-08 18:29:10 UTC
Description of problem:

When using (sybase database) ASEHAagent resource in cluster.conf there is a unique attribute collision on attr=sybase_ase

Version-Release number of selected component (if applicable):

rgmanager-3.0.12-10.el6.x86_64

How reproducible:


Steps to Reproduce:
1. In cluster.conf setup two ASEHAagent resources with the same value for the sybase_ase attribute
2. restart rgmanager
3.
Jun  7 13:51:49 hostname rgmanager[3996]: Reconfiguring
Jun  7 13:51:49 hostname rgmanager[3996]: Loading Service Data
Jun  7 13:51:50 hostname rgmanager[3996]: Unique attribute collision. type=ASEHAagent attr=sybase_home value=/opt/sybase/ASE15
Jun  7 13:51:50 hostname rgmanager[3996]: Error storing ASEHAagent resource
Jun  7 13:51:50 hostname rgmanager[3996]: Unique attribute collision. type=ASEHAagent attr=sybase_ase value=ASE-15_0
Jun  7 13:51:50 hostname rgmanager[3996]: Error storing ASEHAagent resource
Jun  7 13:51:50 hostname rgmanager[3996]: Unique attribute collision. type=ASEHAagent attr=sybase_ase value=ASE-15_0
Jun  7 13:51:50 hostname rgmanager[3996]: Error storing ASEHAagent resource



  
Actual results:
Jun  7 13:51:49 hostname rgmanager[3996]: Reconfiguring
Jun  7 13:51:49 hostname rgmanager[3996]: Loading Service Data
Jun  7 13:51:50 hostname rgmanager[3996]: Unique attribute collision. type=ASEHAagent attr=sybase_home value=/opt/sybase/ASE15
Jun  7 13:51:50 hostname rgmanager[3996]: Error storing ASEHAagent resource
Jun  7 13:51:50 hostname rgmanager[3996]: Unique attribute collision. type=ASEHAagent attr=sybase_ase value=ASE-15_0
Jun  7 13:51:50 hostname rgmanager[3996]: Error storing ASEHAagent resource
Jun  7 13:51:50 hostname rgmanager[3996]: Unique attribute collision. type=ASEHAagent attr=sybase_ase value=ASE-15_0
Jun  7 13:51:50 hostname rgmanager[3996]: Error storing ASEHAagent resource

Expected results:
no unique attribute collision

Additional info:

Comment 1 John Brier 2011-06-08 18:31:35 UTC
FYI RHEL 5 equivalent which hasn't been fixed either

https://bugzilla.redhat.com/show_bug.cgi?id=690265

Comment 6 Chris Feist 2011-06-24 21:52:47 UTC
Before fix:

[root@ask-03 ~]# rg_test test /etc/cluster/cluster.conf | grep Error
Running in test mode.
Loaded 24 resource rules
Error: Unique attribute collision. type=ASEHAagent attr=sybase_home value=/opt/sybase
Error storing ASEHAagent resource
Error: Reference to nonexistent resource syb_ase2 (type ASEHAagent)

After fix (with scratch rpm):
[root@ask-03 ~]# rg_test test /etc/cluster/cluster.conf | grep ErrorRunning in test mode.
Loaded 24 resource rules
[root@ask-03 ~]#

Comment 7 Chris Feist 2011-06-24 21:53:56 UTC
Created attachment 509850 [details]
Cluster.conf used to replicate bug and test fix

Comment 8 Chris Feist 2011-06-30 20:27:37 UTC
Created attachment 510751 [details]
Patch to fix bz

Comment 9 Fabio Massimo Di Nitto 2011-07-08 07:21:50 UTC
http://post-office.corp.redhat.com/archives/cluster-list/2011-June/msg00132.html

Chris packages have been tested and results show that the change works as expected.

Comment 10 Julio Entrena Perez 2011-07-08 08:36:05 UTC
I believe that the "server_name" parameter should remain unique.

Comment 12 Jaroslav Kortus 2011-10-18 12:16:25 UTC
Works as expected with reproducer config.

But according to comment 5 and later also comment 10 the server_name should still be unique and it's not (see the patch). Validation with duplicate server_name still passes the tests, so I'm switching this back to assigned.

Please make server_name unique.

Comment 15 Lon Hohberger 2011-10-18 17:44:33 UTC
Given the simplest possible cluster.conf that would exhibit this behavior:

[root@snap ~]# cat sybasetest.conf 
<cluster>
  <rm>
    <resources>
      <ASEHAagent name="a" sybase_home="b" sybase_ase="c" sybase_ocs="not_unique" server_name="not_unique_test" login_file="a" interfaces_file="a" sybase_user="not_unique" shutdown_timeout="120" start_timeout="120" deep_probe_timeout="120" />
      <ASEHAagent name="b" sybase_home="b" sybase_ase="c" sybase_ocs="not_unique" server_name="not_unique_test" login_file="a" interfaces_file="a" sybase_user="not_unique" shutdown_timeout="120" start_timeout="120" deep_probe_timeout="120" />
    </resources>
  </rm>
</cluster>


Prior to patch (3.9.2-6.el6):

=== Resources List ===
Resource type: ASEHAagent
Agent: ASEHAagent.sh
Attributes:
  name = a [ primary unique ]
  sybase_home = b [ required ]
  sybase_ase = c [ required ]
  sybase_ocs = not_unique [ required ]
  server_name = not_unique_test [ required ]
  login_file = a [ required ]
  interfaces_file = a [ required ]
  sybase_user = not_unique [ required ]
  shutdown_timeout = 120 [ required ]
  start_timeout = 120 [ required ]
  deep_probe_timeout = 120 [ required ]

Resource type: ASEHAagent
Agent: ASEHAagent.sh
Attributes:
  name = b [ primary unique ]
  sybase_home = b [ required ]
  sybase_ase = c [ required ]
  sybase_ocs = not_unique [ required ]
  server_name = not_unique_test [ required ]
  login_file = a [ required ]
  interfaces_file = a [ required ]
  sybase_user = not_unique [ required ]
  shutdown_timeout = 120 [ required ]
  start_timeout = 120 [ required ]
  deep_probe_timeout = 120 [ required ]

=== Event Triggers ===
Event Priority Level 100:
  Name: Default
    (Any event)
    File: /usr/share/cluster/default_event_script.sl

After patch (corrected behavior):

Error: Unique attribute collision. type=ASEHAagent attr=server_name value=not_unique_test
Error storing ASEHAagent resource
Loaded 26 resource rules
=== Resources List ===
Resource type: ASEHAagent
Agent: ASEHAagent.sh
Attributes:
  name = a [ primary unique ]
  sybase_home = b [ required ]
  sybase_ase = c [ required ]
  sybase_ocs = not_unique [ required ]
  server_name = not_unique_test [ unique required ]
  login_file = a [ required ]
  interfaces_file = a [ required ]
  sybase_user = not_unique [ required ]
  shutdown_timeout = 120 [ required ]
  start_timeout = 120 [ required ]
  deep_probe_timeout = 120 [ required ]

=== Event Triggers ===
Event Priority Level 100:
  Name: Default
    (Any event)
    File: /usr/share/cluster/default_event_script.sl

Comment 16 Lon Hohberger 2011-10-18 17:46:28 UTC
Note both the error storing the second resource with the non-unique value and also the change in flags from [ required ] to [ unique required ]

Comment 17 Jaroslav Kortus 2011-10-19 14:57:35 UTC
resource-agents-3.9.2-7.el6.x86_64

works as expected now, server_name unique.

Comment 18 errata-xmlrpc 2011-12-06 12:05:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1580.html