Bug 711952
Summary: | Crashes if being quit while drag'n'dropped files are still being opened. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Hutchison <luke.hutch> | ||||||
Component: | gimp | Assignee: | Nils Philippsen <nphilipp> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 15 | CC: | nphilipp | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | x86_64 | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | abrt_hash:7fef03cab099843030ce9d20f840e40b9ef2e50e | ||||||||
Fixed In Version: | gimp-2.6.11-16.fc15 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2011-06-24 17:57:11 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Luke Hutchison
2011-06-09 05:13:14 UTC
Created attachment 503818 [details]
File: maps
Created attachment 503819 [details]
File: backtrace
It crashes here: --8<--app/display/gimpdisplayshell-dnd.c--gimp_display_shell_drop_uri_list()-- } else if (shell->display->image) <--- line 506 { -->8-------------------------------------------------------------------------- There are only two reasons why this line could crash, either of shell or shell->display could be pointing outside allocated memory which would make dereferencing it blow up. I'm pretty sure that shell is valid at this point because it's set only when the callback gimp_display_shell_drop_uri_list() is registered and assuming that glib isn't broken shouldn't ever be freed until the shell itself is destroyed. That'd leave shell->display which is only ever changed after the shell has been initialized, namely in gimp_display_shell_destroy() when the shell widget is torn down. Luke, I assume that you dragged and dropped a bunch of image files (from your file manager) into GIMP, then while they were loading, exited GIMP. Is that about right? I think that may be right but don't remember exactly, it all happened quite quickly. Yes, I dropped a bunch of images on GIMP. They loaded and the machine started swapping. I don't think I exited from GIMP but I think I did start trying to close one or two images to try to free up memory while the rest were loading. I've reproduced this here with the current master branch from git. Upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=652280 This is fixed upstream in the master and gimp-2-6 branches. gimp-2.6.11-16.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gimp-2.6.11-16.fc15 gimp-2.6.11-16.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gimp-2.6.11-16.fc14 gimp-2.6.11-16.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/gimp-2.6.11-16.fc13 Package gimp-2.6.11-16.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing gimp-2.6.11-16.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/gimp-2.6.11-16.fc15 then log in and leave karma (feedback). gimp-2.6.11-16.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. gimp-2.6.11-16.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |