Bug 712050

Summary: Hotplug disk fail with error: drive hotplug is not supported
Product: Red Hat Enterprise Linux 6 Reporter: weizhang <weizhan>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.2CC: dallan, dyuan, gren, jdenemar, jyang, llim, mzhan, rwu, veillard, yoyzhang, yupzhang
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-0.9.3-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 11:15:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
libvirtd debug log none

Description weizhang 2011-06-09 11:28:42 UTC 
Description of problem:
When hotplug a disk , it will report an error
# virsh attach-disk vr-rhel6-x86_64-kvm /var/lib/libvirt/images/foo.img vda
error: Failed to attach disk
error: operation failed: drive hotplug is not supported

Version-Release number of selected component (if applicable):
kernel-2.6.32-156.el6.x86_64
libvirt-0.9.1-1.el6.x86_64
qemu-kvm-0.12.1.2-2.164.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. install a guest vr-rhel6-x86_64-kvm 
2. create a image with 
# qemu-img create /var/lib/libvirt/images/foo.img 10M
3. hotplug a disk to guest
# virsh attach-disk vr-rhel6-x86_64-kvm /var/lib/libvirt/images/foo.img vda
  
Actual results:
report error:
error: Failed to attach disk
error: operation failed: drive hotplug is not supported

Expected results:
hotplug success with no error

Additional info:
Comment 2 Jiri Denemark 2011-06-09 12:02:14 UTC 
Hmm, it seems drive hotplug went all the way down to HMP passthrough although it should have been handled by __com.redhat_drive_add QMP command. Could you attach libvirtd debug logs of this operation?
Comment 3 weizhang 2011-06-10 02:24:39 UTC 
Created attachment 504006 [details]
libvirtd debug log
Comment 4 weizhang 2011-06-13 01:50:06 UTC 
on libvirt-0.8.7-18.el6.x86_64 , hotplug succeed with no error, so set to regression
Comment 5 Jiri Denemark 2011-06-13 11:45:31 UTC 
Thanks, so __com.redhat_drive_add command was used and succeeded. This a bug in forwardporting libvirt-Support-virtio-disk-hotplug-in-JSON-mode.patch from 6.1.
Comment 6 Jiri Denemark 2011-06-13 12:06:27 UTC 
A fixed version of the patch sent to rhvirt-patches: http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-June/msg00145.html
Comment 7 Daniel Veillard 2011-06-23 03:41:36 UTC 
I apparently missed the patch when building libvirt-0.9.2-1.el6, should be in
next build though !

Daniel
Comment 9 yuping zhang 2011-07-06 07:28:20 UTC 
Reproduced this issue on libvirt-0.9.2-1.el6.x86_64
# virsh attach-disk rhel6 /var/lib/libvirt/images/foo.img vda
error: Failed to attach disk
error: operation failed: drive hotplug is not supported

Tested this issue with:

libvirt-0.9.3-1.el6
qemu-kvm-0.12.1.2-2.167.el6
kernel-2.6.32-164.el6

# virsh attach-disk rhel6 /var/lib/libvirt/images/foo.img vda
Disk attached successfully

#virsh dumpxml rhel6
     .........
    <disk type='block' device='disk'>
      <driver name='qemu' type='raw'/>
      <source dev='/var/lib/libvirt/images/foo.img'/>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </disk>
   ...............

So change the status to VERIFIED
Comment 10 errata-xmlrpc 2011-12-06 11:15:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html