Bug 712661

Summary:	Move VmStatic/VmTemplate properties to VmBase
Product:	[Retired] oVirt	Reporter:	Michael Pasternak <mpastern>
Component:	ovirt-engine-core	Assignee:	lpeer <lpeer>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, bazulay, dyasny, iheim, lpeer, mgoldboi, Rhev-m-bugs, yeylon, ykaul
Target Milestone:	---	Keywords:	CodeChange
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-11 06:41:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Michael Pasternak 2011-06-12 08:51:00 UTC

Description of problem:

when clients creating VM from template they performing several steps:

1. get VmTemplate
2. create VmStatic class (that will be passed to BE later)
3. copy content of VmTemplate to VmStatic class (on property level)
4. override VmStatic class content with content specified by user
5. pass VmStatic class to BE

RFE: both VmStatic and VmTemplate inherits from VmBase, please move
VmStatic properties to VmBase and re-use them at VmTemplate,
(currently the doubled)

this way steps 1 - 3 won't be required and any new feature that will
be added to VmTemplate will be automatically exposed to clients

Comment 1 Itamar Heim 2011-06-12 10:10:39 UTC

1. that's not a code change i see happening for 3.0 (unless trivial)
2. not sure how aligns with DAO's layout.
3. can also be solved with a helper method/command.

Comment 2 Michael Pasternak 2011-06-12 10:19:26 UTC

1. helper method - not good for serialization
2. command - is much more complicated than simple polymorphism

Comment 3 Itamar Heim 2011-06-12 13:00:55 UTC

how does helper method not good for serialization, but polymorphism is?

Comment 4 Michael Pasternak 2011-06-12 13:25:36 UTC

- 'polymorphism' supported at serialization,  
   (eg. VmTemplate::VmBase will be preserved after class serialized so
   BE can require in parameters class VmBase instead of VmStatic)

- 'methods' are not serialized

Comment 5 Itamar Heim 2012-12-11 06:41:14 UTC

Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.