Bug 712968

Summary:	Default state of limit editing checkbox is incorrectly set for "Unlimited" limits
Product:	Red Hat Enterprise MRG	Reporter:	Chad Roberts <croberts>
Component:	cumin	Assignee:	Chad Roberts <croberts>
Status:	CLOSED ERRATA	QA Contact:	Jan Sarenik <jsarenik>
Severity:	low	Docs Contact:
Priority:	low
Version:	Development	CC:	jsarenik, matt, tmckay
Target Milestone:	2.0.1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cumin-0.1.4840-1	Doc Type:	Bug Fix
Doc Text:	C: When going to edit limits, an initial value of "unlimited" would cause the unlimited checkbox to not make sense because its initial state was unchecked. C: The inital value was not being factored-in when displaying the checkbox. F: When displaying the checkbox, we now look at the initial value, if the value is "unlimited", the box will be checked by default. R:	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-09-07 18:34:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	723887

Description Chad Roberts 2011-06-13 18:34:08 UTC

Description of problem:  
On the new edit limits form, if the initial value of the limit to be edited is "Unlimited", the checkbox should be checked (and the field set to read-only), but right now an initial value of "Unlimited" does not have that result (the box is editable and the checkbox is unchecked)


Version-Release number of selected component (if applicable):  Only appears in a devel build


How reproducible: 100%


Steps to Reproduce:
1.  Edit a limit so that the value is "Unlimited"
2.  Go back to the limits page and choose the "unlimited" limit to edit
3.  Note that the checkbox is unchecked and the input box is editable.
  
Actual results:  Note that the checkbox is unchecked and the input box is editable.

Expected results:  The checkbox shoudl be checked and the input box is set to readonly mode


Additional info:

Comment 1 Chad Roberts 2011-06-13 18:56:15 UTC

Fixed in revision 4809.

Comment 2 Jan Sarenik 2011-07-22 12:40:33 UTC

Verified with cumin-0.1.4878-1.el5

Comment 3 Chad Roberts 2011-07-25 14:54:14 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C:  When going to edit limits, an initial value of "unlimited" would cause the unlimited checkbox to not make sense because its initial state was unchecked.

C:  The inital value was not being factored-in when displaying the checkbox.

F:  When displaying the checkbox, we now look at the initial value, if the value is "unlimited", the box will be checked by default.

R: