Bug 713215

Summary: createStorageDomain fails on attribute error, if underlying devices already exist from a former same-structured domain.
Product: Red Hat Enterprise Linux 6 Reporter: Haim <hateya>
Component: vdsmAssignee: Eduardo Warszawski <ewarszaw>
Status: CLOSED ERRATA QA Contact: Daniel Paikov <dpaikov>
Severity: medium Docs Contact:
Priority: high    
Version: 6.2CC: abaron, bazulay, danken, ewarszaw, hateya, iheim, ilvovsky, mgoldboi, yeylon, ykaul
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: vdsm-4.9-76.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 07:22:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vdsm log none

Description Haim 2011-06-14 17:03:01 UTC 
Description of problem:

create storage domain fails on attribute error. 
it appears that function is written with spell mistake; 

    for mapping in mappings:
        if not mappings.startswith(mappingPrefix):
            continue
        try:
            devicemapper.removeMapping(mapping)
        except Exception:
            pass

where it should be: 


   for mapping in mappings:
        if not mapping.startswith(mappingPrefix):
            continue
        try:
            devicemapper.removeMapping(mapping)
        except Exception:
            pass

Thread-20927::ERROR::2011-06-14 19:21:08,202::dispatcher::107::Storage.Dispatcher.Protect::(run) Traceback (most recent call last):
  File "/usr/share/vdsm/storage/dispatcher.py", line 96, in run
    result = ctask.prepare(self.func, *args, **kwargs)
  File "/usr/share/vdsm/storage/task.py", line 1184, in prepare
    raise self.error
AttributeError: 'tuple' object has no attribute 'startswith'


repro:

1) create several storage domains
Comment 1 Haim 2011-06-14 17:04:03 UTC 
Created attachment 504724 [details]
vdsm log
Comment 4 Eduardo Warszawski 2011-06-14 17:27:50 UTC 
http://gerrit.usersys.redhat.com/#change,587
Comment 6 Eduardo Warszawski 2011-06-16 11:30:20 UTC 
Repro:
Two hosts with access to the same SD.
Remove the SD using the spm.
Create a new SD using some of the old luns in the other host.
Comment 9 Daniel Paikov 2011-07-05 12:09:49 UTC 
Checked on 4.9-79.
Comment 10 errata-xmlrpc 2011-12-06 07:22:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1782.html