Bug 713438

Summary: sssd shuts down if inotify crashes
Product: Red Hat Enterprise Linux 6 Reporter: Matthew Mosesohn <mmosesoh>
Component: sssdAssignee: Stephen Gallagher <sgallagh>
Status: CLOSED ERRATA QA Contact: Chandrasekar Kannan <ckannan>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 6.2CC: benl, dpal, grajaiya, jgalipea, jwest, jzeleny, kbanerje, msanders, prc
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sssd-1.5.1-41.el6 Doc Type: Bug Fix
Doc Text:
Previously, SSSD relied on the inotify kernel subsystem to detect whether a DNS resolver file had been changed. If inotify returned an error (for example due to resource exhaustion), SSSD terminated unexpectedly and network logins no longer worked. With this update, SSSD itself detects the failure in the described scenario and falls back to the five-second polling, fixing this bug.
Story Points: ---
Clone Of:
: 748847 (view as bug list) Environment:
Last Closed: 2011-12-06 16:38:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 637248, 716905, 748847    

Description Matthew Mosesohn 2011-06-15 12:54:19 UTC
Description of problem:
SSSD will terminate itself if for some reason it can't use inotify to monitor /etc/resolv.conf

Version-Release number of selected component (if applicable):
kernel-2.6.32-131.0.15.el6.x86_64
sssd-1.5.1-34.el6.x86_64

How reproducible:
intermittent

Steps to Reproduce:
1. set up and run SSSD
2. Suspend
3. Resume from suspend
  
Actual results:
Sometimes SSSD will terminate due to a crash in notification-daemon

Expected results:
SSSD should keep running and not shut down.

Additional info:
This could effectively lock a user out of a system if he or she is not the administrator of the system and has no way to restart SSSD

Comment 2 Stephen Gallagher 2011-06-15 14:11:28 UTC
Upstream ticket opened: https://fedorahosted.org/sssd/ticket/895

Comment 3 Jan Zeleny 2011-06-23 06:53:41 UTC
A reliable way to reproduce:

1. Start sssd
2. Limit the max number of watches per instance to 1 (/proc/sys/fs/inotify/max_user_watches)
3. Make inotify to send an event IN_IGNORED (in my case, just editing and saving it in vim did the trick

Comment 5 Tomas Capek 2011-06-28 08:48:17 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously, SSSD relied on the inotify kernel subsystem to detect whether a DNS resolver file had been changed. If inotify returned an error (for example due to resource exhaustion), SSSD terminated unexpectedly and network logins no longer worked. With this update, SSSD itself detects the failure in the described scenario and falls back to the five-second polling, fixing this bug.

Comment 7 Kaushik Banerjee 2011-09-22 10:52:56 UTC
Verification steps:

1. # echo 1 > /proc/sys/fs/inotify/max_user_watches

2. Open and edit any file.

3. /var/log/sssd/sssd.log shows:
(Thu Sep 22 16:15:08 2011) [sssd] [rewatch_config_file] (1): Could not add inotify watch for file [/etc/resolv.conf]. Error [28:No space left on device]
(Thu Sep 22 16:15:13 2011) [sssd] [rewatch_config_file] (0): Could not restore inotify watch. Switching to polling!

4. # service sssd status
sssd (pid  1894) is running...


Verified in version:
# rpm -qi sssd | head
Name        : sssd                         Relocations: (not relocatable)
Version     : 1.5.1                             Vendor: Red Hat, Inc.
Release     : 52.el6                        Build Date: Tue 20 Sep 2011 09:11:03 PM IST
Install Date: Wed 21 Sep 2011 03:07:04 PM IST      Build Host: x86-010.build.bos.redhat.com
Group       : Applications/System           Source RPM: sssd-1.5.1-52.el6.src.rpm
Size        : 3550647                          License: GPLv3+
Signature   : (none)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
URL         : http://fedorahosted.org/sssd/
Summary     : System Security Services Daemon

Comment 8 errata-xmlrpc 2011-12-06 16:38:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1529.html