Bug 713582

Summary: History list processing has problems with ! in foreach loop
Product: [Fedora] Fedora Reporter: Penelope Fudd <bugzilla.redhat.com>
Component: tcshAssignee: Vojtech Vitek <vvitek>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 14CC: hripps, vvitek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-16 16:35:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Penelope Fudd 2011-06-15 20:17:32 UTC
Description of problem:
I like the new history mechanism of tcsh, where commands inside foreach loops are stored in history, just like bash.  There's a small bug though, in that ! sequences get recorded verbatim, so that the history list contains '!234' instead of the command that was copied from event 234.

Version-Release number of selected component (if applicable):
tcsh-6.17-12.fc14.x86_64.rpm

How reproducible:
Always

Steps to Reproduce:
1. tcsh -f
2. foreach n (1 2 3 4)
3. echo $n
4. end
5. history
6. !1
7. !2
8. end
9. history

  
Actual results:

     1	13:11	foreach n ( 1 2 3 )
     2	13:11	echo $n
     3	13:11	end
     4	13:11	history
     5	13:11	foreach n ( 1 2 3 )
     6	13:12	!2
     7	13:12	end
     8	13:12	history

Expected results:

     1	13:11	foreach n ( 1 2 3 )
     2	13:11	echo $n
     3	13:11	end
     4	13:11	history
     5	13:11	foreach n ( 1 2 3 )
     6	13:12	echo $n
     7	13:12	end
     8	13:12	history


Additional info:

If you type !3 to repeat 'end', the loop doesn't end, it still wants you to type 'end', and then it reports 'end: Not in while/foreach.'.

I managed to get !1 deleted from the history list somehow, but I can't reproduce that now.

Thanks!

Comment 1 Penelope Fudd 2011-06-15 20:19:16 UTC
If you then do 
  !5
  !6
  end
You'll get '!6: Command not found' each time through the loop.

Comment 2 Fedora End Of Life 2012-08-16 16:35:34 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping