| Summary: | Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-http_connection-1.4.1-2.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-21 17:12:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Michal Fojtik
2011-06-16 09:13:57 UTC
(In reply to comment #0) > Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec > SRPM URL: rubygem-rbvmomi-1.2.3-1.fc14.src.rpm > Description: > > Rightscale::HttpConnection is a robust HTTP(S) library. It implements a retry > algorithm for low-level network errors. Sorry, URL for SRPM is: http://mifo.sk/tmp/packages/rubygem-rbvmomi-1.2.3-1.fc14.src.rpm Revision 2: - Added Provides and Obsoletes - Fixed changelog Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec SRPM URL: http://mifo.sk/tmp/packages/rubygem-rbvmomi-1.2.3-2.fc14.src.rpm Sorry for the link chaos, is still morning for me ;-) http://mifo.sk/tmp/packages/rubygem-http_connection-1.4.1-2.fc14.src.rpm I am taking this for review.
According the guidelines for package renaming [1], your provides and obsoletes have to contain correct versions:
Provides: rubygem(%{gemname}) = %{version}
Provides: rubygem-right_http_connection = %{version}
Obsoletes: rubygem-right_http_connection < 1.4.1-1
Also comment that this provides should be removed according to the guidelines would have sense. And don't forget to retire the old package.
Otherwise, the package looks good => APPROVED
[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Thanks for an review Vit! I'll fix that before importing this package. New Package CVS Request ======================= Package Name: rubygem-http_connection Short Description: RightScale's robust HTTP/S connection module Owners: mfojtik Branches: F-14 F-15 EL-5 EL-6 Git done (by process-git-requests). rubygem-http_connection-1.4.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.fc15 rubygem-http_connection-1.4.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.fc14 rubygem-http_connection-1.4.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.el6 rubygem-http_connection-1.4.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. rubygem-http_connection-1.4.1-2.fc14 has been pushed to the Fedora 14 stable repository. rubygem-http_connection-1.4.1-2.fc15 has been pushed to the Fedora 15 stable repository. |