| Summary: | Review Request: perl-PPI-PowerToys - Handy collection of small PPI-based utilities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Emmanuel Seyman <emmanuel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | emmanuel, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | emmanuel:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-PPI-PowerToys-0.14-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-20 12:30:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Petr Pisar
2011-06-17 07:53:54 UTC
Taking. === KEY ===
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3140497
[x] Rpmlint output:
perl-PPI-PowerToys.noarch: E: incorrect-fsf-address /usr/share/doc/perl-PPI-PowerToys-0.14/LICENSE
perl-PPI-PowerToys.noarch: W: no-manual-page-for-binary ppi_version
perl-PPI-PowerToys.noarch: W: no-manual-page-for-binary ppi_copyright
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
Petr, please file a bug upstream asking them to update the FSF address.
Not blocking.
[x] Package is not relocatable.
[x] Buildroot is correct
None specified, default used
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
9cd2c5ad2a4f51f294b0996d8551b8c5 PPI-PowerToys-0.14.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: rawhide.x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3140497
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass
All tests successful.
Files=6, Tests=58, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.99 cusr 0.11 csys = 2.15 CPU)
Result: PASS
APPROVED.
FSF address issue reported to upstream <https://rt.cpan.org/Public/Bug/Display.html?id=68945>. New Package SCM Request ======================= Package Name: perl-PPI-PowerToys Short Description: Handy collection of small PPI-based utilities Owners: ppisar mmaslano psabata Branches: f15 InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. perl-PPI-PowerToys-0.14-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-PPI-PowerToys-0.14-1.fc15 perl-PPI-PowerToys-0.14-1.fc15 has been pushed to the Fedora 15 stable repository. |