Bug 714047 (nifticlib)

[ankur@ankur SRPMS]$ rpmlint ../SPECS/nifticlib.spec nifticlib-2.0.0-1.fc15.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm
../SPECS/nifticlib.spec:53: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/*
../SPECS/nifticlib.spec:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/
../SPECS/nifticlib.spec: W: invalid-url Source0: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz HTTP Error 404: Not Found
nifticlib.src: W: spelling-error Summary(en_US) nifti -> nifty
nifticlib.src: W: spelling-error %description -l en_US nifti -> nifty
nifticlib.src: W: spelling-error %description -l en_US fMRI -> MRI, f MRI, firm
nifticlib.src:53: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/*
nifticlib.src:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/
nifticlib.src: W: invalid-url Source0: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz HTTP Error 404: Not Found
nifticlib.i686: W: spelling-error Summary(en_US) nifti -> nifty
nifticlib.i686: W: spelling-error %description -l en_US nifti -> nifty
nifticlib.i686: W: spelling-error %description -l en_US fMRI -> MRI, f MRI, firm
nifticlib.i686: W: no-manual-page-for-binary nifti_stats
nifticlib.i686: W: no-manual-page-for-binary nifti_tool
nifticlib.i686: W: no-manual-page-for-binary nifti1_test
nifticlib.src: W: spelling-error Summary(en_US) nifti -> nifty
nifticlib.src: W: spelling-error %description -l en_US nifti -> nifty
nifticlib.src: W: spelling-error %description -l en_US fMRI -> MRI, f MRI, firm
nifticlib.src:53: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/*
nifticlib.src:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/
nifticlib.src: W: invalid-url Source0: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz HTTP Error 404: Not Found
nifticlib-devel.i686: W: no-documentation
6 packages and 1 specfiles checked; 6 errors, 16 warnings.


The errors are irrelevant here.

Package source matches upstream:

$ sha1sum ../nifticlib-2.0.0.tar.gz nifticlib-2.0.0.tar.gz 
3a6187cb09767f97cef997cf492d89ac3db211df  ../nifticlib-2.0.0.tar.gz
3a6187cb09767f97cef997cf492d89ac3db211df  nifticlib-2.0.0.tar.gz

Source0 URL is WRONG:

WRONG: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz
Right: http://downloads.sourceforge.net/niftilib/nifticlib-2.0.0.tar.gz

Try 'wget'-ing both URLs.

Koji scratch build worked:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3231346

I agree that the other rpmlint warnings can be ignored,
including the one about /usr/lib which is bogus.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ consistent use of macros
+ package must contain code or permissible content
+ large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
+ header files should be in -devel
n/a static libraries should be in -static
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
+ libfoo.so must go in -devel
+ -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
n/a packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if available
+ reviewer should build the package in mock
? the package should build into binary RPMs on all supported architectures
? review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

Package is not approved.  Please just fix the Source URL.

Corrected:

Fresh srpm/spec:

http://ankursinha.fedorapeople.org/nifticlib/nifticlib.spec

http://ankursinha.fedorapeople.org/nifticlib/nifticlib-2.0.0-2.fc15.src.rpm

Thank you for the *quick* review Richard!
Ankur

Looks good.

-----------------

This package is APPROVED by rjones

-----------------

Thank you Richard!

New Package SCM Request
=======================
Package Name: nifticlib
Short Description: A set of i/o libraries for reading and writing files in the nifti-1 data format
Owners: ankursinha
Branches: f14 f15
InitialCC: susmit mrceresa

Git done (by process-git-requests).

nifticlib-2.0.0-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/nifticlib-2.0.0-2.fc15

nifticlib-2.0.0-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/nifticlib-2.0.0-2.fc14

Built for rawhide and pushed to f14 f15 for testing. Closing.

nifticlib-2.0.0-2.fc14 has been pushed to the Fedora 14 stable repository.

nifticlib-2.0.0-2.fc15 has been pushed to the Fedora 15 stable repository.