Bug 714141

Summary:	Review Request: rubygem-multipart - Add multipart (file upload) support to Net::HTTP::Post
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	Package Review	Assignee:	Marcela Mašláňová <mmaslano>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	mmaslano: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-22 11:02:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	705508

Description Vít Ondruch 2011-06-17 12:35:28 UTC

Spec URL: http://people.redhat.com/vondruch/rubygem-multipart.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-multipart-0.2.1-1.fc16.src.rpm
Description: Multipart is a gem that adds support to multipart/form-encoded and
multipart/mixed (file upload) to Net::HTTP::Post.  Nothing more, nothing less.
Currently it supports a file param with multiple files, but not multiple file
params.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3137438

Comment 1 Marcela Mašláňová 2011-07-21 13:30:55 UTC

- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

APPROVED

Comment 2 Vít Ondruch 2011-07-22 09:49:01 UTC

Thank you for your review!



New Package SCM Request
=======================
Package Name: rubygem-multipart
Short Description: Add multipart (file upload) support to Net::HTTP::Post
Owners: vondruch
Branches: 
InitialCC:

Comment 3 Gwyn Ciesla 2011-07-22 10:22:31 UTC

Git done (by process-git-requests).