| Summary: | RFE: add v7-qa rpm for qa tests | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | Caspar Zhang <czhang> |
| Component: | Test Suite (tests) | Assignee: | Caspar Zhang <czhang> |
| Status: | CLOSED NOTABUG | QA Contact: | Red Hat Kernel QE team <kernel-qe> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.3 | CC: | gnichols, qcai, rlandry, ykun |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-27 15:08:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Caspar Zhang
2011-06-22 08:27:02 UTC
I have built a patch on my own repo: http://git.engineering.redhat.com/?p=users/czhang/v7.git;a=commitdiff;h=31cc80ab0cf9719461806ff37647214a09dda67f (but not tested yet) Since Comment 1, I've changed the v7-server package to be a subpackage, and I'd suggest we do the same for v7-qa. We should probably think a bit about the naming. v7-qa seems a bit generic, but maybe that's ok. (In reply to comment #3) > Since Comment 1, I've changed the v7-server package to be a subpackage, and I'd > suggest we do the same for v7-qa. Since QE will be the person who maintain qa tests in most cases, I'm suggesting less coupling between v7/v7-server and v7-qa. I put all Makefile changes to a file named Makefile.osqa and in Makefile we just "include Makefile.osqa". This is easy for Greg to do some modifications in Makefile and not break either v7 or v7-qa package. > > We should probably think a bit about the naming. v7-qa seems a bit generic, > but maybe that's ok. I see a tag named "osqa", so I changed the name to v7-osqa. New version: http://git.engineering.redhat.com/?p=users/czhang/v7.git;a=shortlog;h=osqa I have tested osqa package and it worked well. (In reply to comment #4) > Since QE will be the person who maintain qa tests in most cases, I'm suggesting > less coupling between v7/v7-server and v7-qa. I put all Makefile changes to a > file named Makefile.osqa and in Makefile we just "include Makefile.osqa". This > is easy for Greg to do some modifications in Makefile and not break either v7 > or v7-qa package. I'm not sure how making v7-qa a separate package really changes the coupling. These tests use library code (/v7/v7), for example. If v7-qa is going to be in a different repo, all you'd need is a Makefile/packaging to install the test code under v7's test library directory (defined in /etc/v7.xml, default: /usr/share/v7/tests). Test classes that are subclassed off of v7/test.py, and are in the test library directory will automatically be picked up by v7 at plan time. There's no need to patch v7 for this. That said, I think it would be better to keep all the tests in the same repo, built via the same brew builds, etc. And if the code is in a single repo, subpackages are a lot simpler to maintain. I'm closing this as it seems the best path is to have v7-qa a completely separaate source and package that depends on v7. v7-qa can be developed with no changes necessary for v7. *** Bug 638822 has been marked as a duplicate of this bug. *** *** Bug 638819 has been marked as a duplicate of this bug. *** |