Bug 715293

Summary:	condor_userprio should print error when condor is not running
Product:	Red Hat Enterprise MRG	Reporter:	Lubos Trilety <ltrilety>
Component:	condor	Assignee:	Erik Erlandson <eerlands>
Status:	CLOSED ERRATA	QA Contact:	Martin Kudlej <mkudlej>
Severity:	low	Docs Contact:
Priority:	low
Version:	2.0	CC:	iboverma, matt, mkudlej, tstclair
Target Milestone:	2.1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	condor-7.6.4-0.5	Doc Type:	Bug Fix
Doc Text:	When the condor_userprio utility detected failure to locate the Negotiator daemon, no error message was returned to inform users. With this update, an informative error message has been added to the failure detection code path and users are now properly informed in the described scenario.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-23 17:27:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	743350

Description Lubos Trilety 2011-06-22 13:27:51 UTC

Description of problem:
When condor is not running and condor_userprio was run it prints just 'condor_userprio:' and finishes. It should print some error message as other tools (condor_q, condor_status, ..)

Version-Release number of selected component (if applicable):
condor-7.6.1-0.10

How reproducible:
100%

Steps to Reproduce:
1. stop condor

2. run 'condor_userprio'
# condor_userprio
condor_userprio: 
#

  
Actual results:
condor_userprio ends without proper error message, that it cannot connect to condor (negotiator)

Expected results:
condor_userprio prints correct error message

Additional info:

Comment 1 Erik Erlandson 2011-09-20 02:53:00 UTC

upstream: https://condor-wiki.cs.wisc.edu/index.cgi/tktview?tn=2478

Comment 2 Erik Erlandson 2011-09-20 03:00:55 UTC

    REPRO/TEST

    No configuration is required. Repro is easiest if pool is halted:

    $ condor_off -master


    Before fix: when pool is halted so condor_userprio can't locate the negotiator, there is not a good error msg:

    $ condor_userprio
    condor_userprio:

    $ condor_userprio -pool fred
    condor_userprio:


    After fix: error message is informative:

    $ condor_userprio
    condor_userprio: Can't locate negotiator in local pool

    $ condor_userprio -pool fred
    condor_userprio: Can't locate negotiator in fred

Comment 3 Erik Erlandson 2011-09-23 23:55:50 UTC

Committed fix to uw/V7_6-branch

Comment 4 Erik Erlandson 2011-09-23 23:55:50 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:
Lack of error message text output when condor_userprio detects failure to locate the negotiator.

Consequence:
User does not have informative message to explain failure.

Fix:
Informative error message added to the failure detection code path.

Result:
User will now be properly informed when condor_userprio cannot locate the negotiator.

Comment 6 Martin Kudlej 2011-10-19 15:48:15 UTC

Teste in RHEL5.8/6.1 x x86_64/i386 with condor-7.6.4-0.8 and it works. -->VERIFIED

Comment 7 Tomas Capek 2011-11-17 12:34:50 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,11 +1 @@
-Cause:
+When the condor_userprio utility detected failure to locate the Negotiator daemon, no error message was returned to inform users. With this update, an informative error message has been added to the failure detection code path and users are now properly informed in the described scenario.-Lack of error message text output when condor_userprio detects failure to locate the negotiator.
-
-Consequence:
-User does not have informative message to explain failure.
-
-Fix:
-Informative error message added to the failure detection code path.
-
-Result:
-User will now be properly informed when condor_userprio cannot locate the negotiator.

Comment 8 errata-xmlrpc 2012-01-23 17:27:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0045.html