Bug 715402
| Summary: | [RFE] - run cryptographic tests as part of the nss-softokn build | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elio Maldonado Batiz <emaldona> | ||||||||||||
| Component: | nss-softokn | Assignee: | Elio Maldonado Batiz <emaldona> | ||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||
| Priority: | unspecified | ||||||||||||||
| Version: | rawhide | CC: | emaldona, kengert, rrelyea | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | nss-softokn-3.12.10-5.fc15 | Doc Type: | Bug Fix | ||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2011-11-25 02:20:27 UTC | Type: | --- | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Elio Maldonado Batiz
2011-06-22 18:42:37 UTC
Created attachment 506068 [details]
Enables running the bltest suite as part of the build
Comment on attachment 506068 [details]
Enables running the bltest suite as part of the build
The tests use the sectool static library for various services, among them error reporting, which brings dependencies on higher layers of nss. This patch includes a stripped-down version of the test utilities with such dependencies removed. This portion is temporary workaround until certain patches proposed upstream are approved and we upgrade.
I find the attached patch difficult to read, because most of it is a "diff of a patch". I'm splitting it into two separate files, for easier reviewing, and I'll remove the initial "+" from the diffed patch. Created attachment 512691 [details]
subset 1, the changes to the RPM scripts
Created attachment 512692 [details]
subset 2, the included patch to NSS
Created attachment 512693 [details]
subset 2, the included patch to NSS (fixed)
Created attachment 512694 [details]
subset 2, the included patch to NSS (for real this time)
Comment on attachment 512694 [details]
subset 2, the included patch to NSS (for real this time)
This patch is still somewhat tricky to review.
For example, secu_PrintRSAPublicKey is not removed, but the patch gives the impression that it's newly added.
It's sometimes helpful to use "diff --minimal" to try harder to detect deletions, which may have helped here.
Comment on attachment 512694 [details]
subset 2, the included patch to NSS (for real this time)
Despite not easy to know for sure from this patch, it appears, your code changes to NSS are limited to "removing code from NSS".
The interesting piece is at the end of the patch, where you modify the build scripts.
In "all.sh", you're modifying an existing comment. I would rather keep the original comment, and below it, I'd add something like this:
####################################################
# -- testing softokn module --
# This modified copy of all.sh builds a reduced set of directories.
# We check for the latest item being built.
# See variable DIRS in security/nss/cmd/manifest.mn
####################################################
Comment on attachment 506068 [details]
Enables running the bltest suite as part of the build
r=kaie
seems reasonable for your testing needs
Kai, My apologies for you having to deal for such a messy patch. I meant to replace with something cleaner that could be easily and cleanly applied and forgot to do it. I will incorporate your suggestion. Thanks the review! nss-softokn-3.12.10-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nss-softokn-3.12.10-4.fc15 Package nss-softokn-3.12.10-4.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nss-softokn-3.12.10-4.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/nss-softokn-3.12.10-4.fc15 then log in and leave karma (feedback). nss-softokn-3.12.10-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nss-softokn-3.12.10-5.fc15 Package nss-softokn-3.12.10-5.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nss-softokn-3.12.10-5.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-14415 then log in and leave karma (feedback). nss-softokn-3.12.10-5.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |