Bug 715498 (elmer-hutiter)

Summary:	Review Request: elmer-hutiter - Open Source Finite Element Software for Multiphysical Problems
Product:	[Fedora] Fedora	Reporter:	Ankur Sinha (FranciscoD) <sanjay.ankur>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, volker27
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-10-15 04:57:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	715620, 716344

Description Ankur Sinha (FranciscoD) 2011-06-23 05:18:28 UTC

Spec URL: http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter.spec
SRPM URL:
http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter-20110618-0.1svn5236.fc15.src.rpm

Description: 
Elmer is an open source multiphysical simulation software 
developed by CSC - IT Center for Science (CSC). Elmer development 
was started 1995 in collaboration with Finnish Universities, 
research institutes and industry.

Elmer includes physical models of fluid dynamics, structural 
mechanics, electromagnetics, heat transfer and acoustics, for 
example. These are described by partial differential equations 
which Elmer solves by the Finite Element Method (FEM).

Comment 1 Ankur Sinha (FranciscoD) 2011-06-23 14:10:42 UTC

http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter.spec

http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter-20110623-0.1svn5244.fc15.src.rpm

Comment 2 Ankur Sinha (FranciscoD) 2011-08-07 12:19:41 UTC

http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter.spec

http://ankursinha.fedorapeople.org/elmer/hutiter/elmer-hutiter-0-0.1.20110807.svn5280.fc15.src.rpm

Comment 3 Volker Fröhlich 2011-08-26 20:53:16 UTC

Please adapt the BR syntax according to the new ruling:

http://fedoraproject.org/wiki/PackagingGuidelines#Requiring_Base_Package

Drop "-n %{name}".

Defattr is no longer necessary.

Probably be a bit more specific in the files section. Also label the documentation as such.

Installing via install -p -m 0644 AUTHORS ChangeLog COPYING NEWS README -t $RPM_BUILD_ROOT/%{_docdir}/hutiter/ and so on is wrong. Use the %doc macro.

Is it possible to build shared libs?

I'm not a hundred percent sure if the package is really GPLv2+. Do you have a statement somewhere?

Comment 4 Ankur Sinha (FranciscoD) 2011-08-28 04:24:02 UTC

The main elmer project is GPLv2+. These are just submodules required to build it. I was initially packaging them together in one spec but they need to be built before the main elmer software can be built. 

I'll go make the corrections. 

Thanks,,
Ankur

Comment 5 Ankur Sinha (FranciscoD) 2011-10-15 04:57:37 UTC

Hi,

I'm not working on -medical related packages anymore and will not be pursuing this review ticket. If someone else wishes to take up the review, please open a new ticket. 

Thanks,
Ankur