Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
This issue is introduced by libvirt-Support-seemless-migration-of-SPICE-graphics-clients.patch, the function qemuMonitorJSONMigrateCancel is using variable 'type', 'hostname', 'port', 'tlsPort' and 'tlsSubject', however, these variables haven't been declared before usage, so will meet compile error when run 'make'.
Version-Release number of selected component (if applicable):
libvirt-0.9.2-1.el6.src.rpm
How reproducible:
always
Steps to Reproduce:
1. rpm -ivh http://download.devel.redhat.com/brewroot/packages/libvirt/0.9.2/1.el6/src/libvirt-0.9.2-1.el6.src.rpm
2. /root/rpmbuild/SOURCES/libvirt-0.9.2
3. apply all of pathes under the /root/rpmbuild/SOURCES dir
4. compile libvirt source code
Actual results:
CC libvirt_driver_qemu_la-qemu_monitor_json.lo
qemu/qemu_monitor_json.c: In function 'qemuMonitorJSONMigrateCancel':
qemu/qemu_monitor_json.c:1946: error: 'type' undeclared (first use in this function)
qemu/qemu_monitor_json.c:1946: error: (Each undeclared identifier is reported only once
qemu/qemu_monitor_json.c:1946: error: for each function it appears in.)
qemu/qemu_monitor_json.c:1953: error: 'hostname' undeclared (first use in this function)
qemu/qemu_monitor_json.c:1954: error: 'port' undeclared (first use in this function)
qemu/qemu_monitor_json.c:1955: error: 'tlsPort' undeclared (first use in this function)
qemu/qemu_monitor_json.c:1956: error: 'tlsSubject' undeclared (first use in this function)
Expected results:
Fix it.
Additional info:
I try to apply a patch to fix this issue, it's okay to add the corresponding variables declaration for src/qemu/qemu_monitor.h,
src/qemu/qemu_monitor.c, src/qemu/qemu_monitor_json.h and src/qemu/qemu_monitor_json.c, however, I find the qemuMonitorMigrateCancel function is called by qemuMigrationProcessJobSignals function in src/qemu/qemu_migration.c,
that means I need to modify qemuMigrationProcessJobSignals function interface,
meanwhile, I need also to update other function interface such as qemuMigrationWaitForCompletion, it's not good idea.
The root reason is patches applied sequence issue, I haven't followed patches
sequence in SPECS/libvirt.spec, hence I met the above issue, the normal patches
sequence look like this:
# Patches
Patch1: libvirt-Turn-on-JSON-mode-and-netdev-usage-for-RHEL6-binary.patch
Patch2: libvirt-Support-virtio-disk-hotplug-in-JSON-mode.patch
Patch3: libvirt-Support-password-expiry-in-the-QEMU-driver.patch
Patch4: libvirt-Support-seemless-migration-of-SPICE-graphics-clients.patch
Patch5:
libvirt-Emit-graphics-events-when-a-SPICE-client-connects-disconnects.patch
Patch6:
libvirt-Switch-to-private-redhat-namespace-for-QMP-I-O-error-reason.patch
Patch7: libvirt-Disable-KSM-on-domain-startup.patch
Changing the bug to NOTABUG.
Alex