Bug 715973

Summary:	Multitude of "Edit Ad: OK" messages
Product:	Red Hat Enterprise MRG	Reporter:	Jan Sarenik <jsarenik>
Component:	cumin	Assignee:	Chad Roberts <croberts>
Status:	CLOSED ERRATA	QA Contact:	Jan Sarenik <jsarenik>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.0	CC:	croberts, matt, tmckay
Target Milestone:	2.0.1
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	cumin-0.1.4863-1	Doc Type:	Bug Fix
Doc Text:	Consequence: Hitting submit on the edit attributes page for a job would result in 15 edits being attempted that may or may not have actually been intended. Cause: The code was not handling boolean values properly and was treating their values as changed the first time you edited the attributes for a job...subsequent edits would work as expected. Fix: We are now properly handling the boolean values (radio buttons) on the edit job attribute page. Result: Editing attributes should now result in an appropriate number of entries in the task indicator (yellow box) after editing job attributes.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-09-07 16:42:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	723887

Description Jan Sarenik 2011-06-23 15:49:25 UTC

When the Grid submission job's arguments are saved,
you get lots of "Edit Ad: OK" messages in the yellow
status box.

cumin-0.1.4840-1.el6 (already beyond MRG 2.0)

How reproducible: 100%

Steps to Reproduce:
1. Submit a job.
2. View it, press Edit Attributes, press Submit (even without
  editing anything).

Actual results: Lots of "Edit Ad: OK" messages emitted.

Expected results: There should be no message for arguments that
  were not changed.

Comment 1 Chad Roberts 2011-06-23 19:03:26 UTC

Fixed in revision 4850

Comment 2 Chad Roberts 2011-06-23 19:03:26 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Consequence:  Hitting submit on the edit attributes page for a job would result in 15 edits being attempted that may or may not have actually been intended.

Cause:  The code was not handling boolean values properly and was treating their values as changed the first time you edited the attributes for a job...subsequent edits would work as expected.

Fix:  We are now properly handling the boolean values (radio buttons) on the edit job attribute page.

Result:  Editing attributes should now result in an appropriate number of entries in the task indicator (yellow box) after editing job attributes.

Comment 4 Jan Sarenik 2011-07-22 12:22:43 UTC

Verified with cumin-0.1.4878-1.el5

Comment 5 errata-xmlrpc 2011-09-07 16:42:57 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-1249.html