Bug 716330

Summary:

rm multiple files needs -f in test-update-copyright.sh

Product:

[Fedora] Fedora

Reporter:

JW <ohtmvyyn>

Component:

grep

Assignee:

Jaroslav Škarvada <jskarvad>

Status:

CLOSED RAWHIDE

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

high

Docs Contact:

Priority:

unspecified

Version:

rawhide

CC:

jskarvad, lkundrak

Target Milestone:

---

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2011-07-11 10:14:12 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
Proposed fix	none

Description JW 2011-06-24 02:09:20 UTC

Description of problem:
In the file gnulib-tests/test-update-copyright.sh there are a number of invocations of "rm" on multiple files without a "-f" option.

Version-Release number of selected component (if applicable):
grep-2.7-5

How reproducible:
Always

Steps to Reproduce:
1. grep 'rm ' gnulib-tests/*.sh | grep -v '[-]r*f'
2.
3.
  
Actual results:
1. gnulib-tests/test-update-copyright.sh:rm $TMP*

Expected results:
1.

Additional info:
Please patch the script to use 'rm -f $TMP*'.

If you looks everywhere else (in grep.spec, in Makefiles, in tests/*.sh) you will see that the right thing is always done. They use 'rm -f' so that there is zero likelihood that 'rm' will try prompting to remove a file (because of permissions, or because a variant of 'rm', which prompts by default when confronted with multiple files, is installed).

Comment 1 Jaroslav Škarvada 2011-07-11 09:52:26 UTC

Created attachment 512163 [details]
Proposed fix

Comment 2 Jaroslav Škarvada 2011-07-11 10:04:23 UTC

I recognize this to be a very minor problem, thus I am moving it to rawhide.

Justification: Currently it doesn't cause any problem in build system and most users do not rebuild the package, thus it is probably not worth to let the fix go through critical path update process.

I will also report this to upstream.

If you need the F15 fix, please comment here, otherwise I will backport it to F15 in case of another bugfix update.

Comment 3 Jaroslav Škarvada 2011-07-11 10:14:12 UTC

Upstream ticket:
http://savannah.gnu.org/bugs/index.php?33747