Bug 716421

Summary:	cups package doesn't tag localization files correctly
Product:	[Fedora] Fedora	Reporter:	Mads Kiilerich <mads>
Component:	cups	Assignee:	Tim Waugh <twaugh>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	14	CC:	jpopelka, twaugh
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cups-1.4.7-3.fc15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-08 18:04:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mads Kiilerich 2011-06-24 11:30:36 UTC

Description of problem:
When building a live live cd with 
%packages --instLangs=en_US.UTF8
the cups package installs other localizations anyway.

Version-Release number of selected component (if applicable):

cups-1.4.6-1.fc14.i686 - but apparently same issue in rawhide

Additional info:

Specs should use %find_lang but cups doesn't. I guess that would fix it.

Comment 1 Mads Kiilerich 2011-06-24 12:09:20 UTC

Correction: %find_lang probably needs --all-name because of the naming of the locale files (as described on bug 716426 )

Other localized files such as /usr/share/cups/templates/*/*.tmpl should perhaps be marked up manually.

Comment 2 Tim Waugh 2011-06-28 15:56:46 UTC

When trying this locally I get:

+ /usr/lib/rpm/find-lang.sh /builddir/build/BUILDROOT/cups-1.4.7-2.fc14.x86_64 cups --all-name
No translations found for cups in /builddir/build/BUILDROOT/cups-1.4.7-2.fc14.x86_64

Is it possible to use find_land for this, or would it need to be done manually?

Comment 3 Tim Waugh 2011-06-28 16:14:08 UTC

Oh, probably the reason is that CUPS uses uncompiled po files (i.e. it doesn't use gettext), and so find-lang.sh doesn't find any *.mo files to work on.

Comment 4 Mads Kiilerich 2011-06-28 20:12:13 UTC

Yes, it seems like you are right - and there doesn't seem to be any way to make find-lang.sh do the right thing.

I guess something like this could be used instead:

find $RPM_BUILD_ROOT -type f -o -type l | sed '
s:.*\(/usr/share/locale/\)\([^/_]\+\)\(.*\.po$\):%lang(\2) \1\2\3:
/^%lang(C)/d
/^\([^%].*\)/d
' > cups.lang

Comment 5 Tim Waugh 2011-06-29 09:45:12 UTC

Fixed in:
  cups-1.4.7-2.fc14
  cups-1.4.7-3.fc15
  cups-1.5-0.8.rc1.fc16

Thanks.

Comment 6 Fedora Update System 2011-06-29 10:16:00 UTC

cups-1.4.7-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/cups-1.4.7-3.fc15

Comment 7 Fedora Update System 2011-06-29 22:00:24 UTC

Package cups-1.4.7-3.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing cups-1.4.7-3.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/cups-1.4.7-3.fc15
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2011-06-30 07:37:30 UTC

cups-1.4.7-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/cups-1.4.7-2.fc14

Comment 9 Fedora Update System 2011-07-08 18:04:15 UTC

cups-1.4.7-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2011-08-19 12:03:54 UTC

cups-1.4.8-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/cups-1.4.8-2.fc14

Comment 11 Fedora Update System 2011-09-09 05:24:32 UTC

cups-1.4.8-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.