Bug 716697
| Summary: | Review Request: perl-FusionInventory-Agent-Task-ESX - vCenter/ESX/ESXi remote inventory for FusionInventory Agent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Haïkel Guémar <karlthered> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, karlthered, notting |
| Target Milestone: | --- | Flags: | karlthered:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | fusioninventory-agent-2.1.9-3.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-17 00:55:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 716695 | ||
| Bug Blocks: | |||
|
Description
Remi Collet
2011-06-26 13:37:14 UTC
Update to 1.1.2 : https://github.com/remicollet/remirepo/commit/35b68d8913ee75680c0f0538249e3102b25c4bcd SRPM: http://rpms.famillecollet.com/SRPMS/perl-FusionInventory-Agent-Task-ESX-1.1.2-1.remi.src.rpm perl-FusionInventory-Agent-Task-ESX (Perl package) MUST: rpmlint must be run on src.rpm and rpm. OK $ rpmlint perl-FusionInventory-Agent-Task-ESX-1.1.2-1.fc17.src.rpm perl-FusionInventory-Agent-Task-ESX.src: W: spelling-error Summary(en_US) vCenter -> v Center, center, cementer perl-FusionInventory-Agent-Task-ESX.src: W: summary-not-capitalized C vCenter/ESX/ESXi remote inventory for FusionInventory Agent perl-FusionInventory-Agent-Task-ESX.src: W: spelling-error %description -l en_US vCenter -> v Center, center, cementer perl-FusionInventory-Agent-Task-ESX.src: W: spelling-error %description -l en_US ocsinventory -> inventory 1 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpmlint -iv perl-FusionInventory-Agent-Task-ESX-1.1.2-1.fc17.noarch.rpm (0) perl-FusionInventory-Agent-Task-ESX.noarch: I: checking perl-FusionInventory-Agent-Task-ESX.noarch: W: spelling-error Summary(en_US) vCenter -> v Center, center, cementer The value of this tag appears to be misspelled. Please double-check. perl-FusionInventory-Agent-Task-ESX.noarch: W: summary-not-capitalized C vCenter/ESX/ESXi remote inventory for FusionInventory Agent Summary doesn't begin with a capital letter. perl-FusionInventory-Agent-Task-ESX.noarch: W: spelling-error %description -l en_US vCenter -> v Center, center, cementer The value of this tag appears to be misspelled. Please double-check. perl-FusionInventory-Agent-Task-ESX.noarch: W: spelling-error %description -l en_US ocsinventory -> inventory The value of this tag appears to be misspelled. Please double-check. perl-FusionInventory-Agent-Task-ESX.noarch: I: checking-url http://forge.fusioninventory.org/projects/fusioninventory-agent-task-esx (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 4 warnings. The non-capitalized summary is ok, since it would alter the proper spelling of vCenter. MUST: package named accordingly to package naming guidelines. OK MUST: spec file name match %{name} OK MUST: package meets packaging guidelines OK MUST: package must be licensed under a fedora-compliant license OK (GPLv2+) MUST: License field in package spec match actual license OK License file included and distributed MUST: spec in legible american english OK MUST: sources provided match upstream's OK provided sources sha1sum: dc5b24fe1e9f0f7d288448cc34435363a42566f9 upstream sources sha1sum: dc5b24fe1e9f0f7d288448cc34435363a42566f9 MUST: package successfully compiles on at least one primary architecture OK (all of them) MUST: all build dependencies are listed in BR KO MUST: package must own all directories it creates OK MUST: package does not list a file more than once in %files section OK MUST: permissions are properly set OK MUST: package consistenly use macros OK MUST: package contains permissable content OK MUST: package does not own directories owned by other packages OK MUST: all filenames in package are valid UTF-8 OK SHOULD: mock builds were done on rawhide on all primary architectures (x86/x86_64) KO tests fail due to missing BR: perl(LWP::Protocol::https) I added it and mock builds went fine SHOULD: man pages are provided OK This package respects general & Perl Fedora Packaging guidelines, as soon as the missing BR will be added, it will be approved add BR perl(LWP::Protocol::https) for fedora 16 build : https://github.com/remicollet/remirepo/commit/9a06c6cc1d94c9f2c8be1285794c97505ad49dc1 New SRPM: http://rpms.famillecollet.com/SRPMS/perl-FusionInventory-Agent-Task-ESX-1.1.2-2.remi.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3258543 All points above are still OK, the missing BR has been added, it builds fine under rawhide. I hereby approve this package to join his brothers in Fedora Packages Collection. Thanks for the review :) New Package SCM Request ======================= Package Name: perl-FusionInventory-Agent-Task-ESX Short Description: vCenter/ESX/ESXi remote inventory for FusionInventory Agent Owners: remi Branches: f14 f15 f16 el6 InitialCC: Git done (by process-git-requests). fusioninventory-agent-2.1.9-3.fc16,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fusioninventory-agent-2.1.9-3.fc16,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 fusioninventory-agent-2.1.9-3.fc15,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc15,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc15,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc15,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fusioninventory-agent-2.1.9-3.fc15,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc15,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc15,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc15,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc15 fusioninventory-agent-2.1.9-3.fc14,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc14,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc14,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc14,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fusioninventory-agent-2.1.9-3.fc14,perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc14,perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc14,perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc14,perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc14 fusioninventory-agent-2.1.9-3.fc16, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 has been pushed to the Fedora 16 testing repository. fusioninventory-agent-2.1.9-3.fc14, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc14, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc14, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc14, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc14 has been pushed to the Fedora 14 stable repository. fusioninventory-agent-2.1.9-3.fc15, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc15, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc15, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc15, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc15 has been pushed to the Fedora 15 stable repository. fusioninventory-agent-2.1.9-3.fc16, perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc16, perl-FusionInventory-Agent-Task-OcsDeploy-1.1.0-3.fc16, perl-FusionInventory-Agent-Task-ESX-1.1.2-2.fc16, perl-FusionInventory-Agent-Task-SNMPQuery-1.3-1.fc16 has been pushed to the Fedora 16 stable repository. |