Bug 716779

Summary: Review Request: perl-HTML-FormatText-WithLinks-AndTables - Converts HTML to Text with tables intact
Product: [Fedora] Fedora Reporter: Ruediger Landmann <rlandman>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade, ppisar
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-27 21:26:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Ruediger Landmann 2011-06-27 03:28:15 UTC
Spec URL:
http://rlandmann.fedorapeople.org/packages/perl-HTML-FormatText-WithLinks-AndTables.spec

SRPM URL:
http://rlandmann.fedorapeople.org/packages/perl-HTML-FormatText-WithLinks-AndTables-0.01-2.fc15.src.rpm

Description: 
This module was inspired by HTML::FormatText::WithLinks which has proven to
be a useful "lynx -dump" work-alike. However one frustration was that no
other HTML converters I came across had the ability to deal effectively
with HTML <TABLE>s. This module can in a rudimentary sense do so. The aim
was to provide facility to take a simple HTML based email template, and to
also convert it to text with the <TABLE> structure intact for inclusion as
"multi-part/alternative" content. Further, it will preserve both the
formatting specified by the <TD> tag's "align" attribute, and will also
preserve multi-line text inside of a <TD> element provided it is broken
using <BR/> tags.

rpmlint output:
$ rpmlint SPECS/perl-HTML-FormatText-WithLinks-AndTables.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/perl-HTML-FormatText-WithLinks-AndTables-0.01-2.fc15.src.rpm
perl-HTML-FormatText-WithLinks-AndTables.src: W: spelling-error %description -l en_US multi -> mulch, mufti
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint RPMS/noarch/perl-HTML-FormatText-WithLinks-AndTables-0.01-2.fc15.noarch.rpm

scratchbuild on Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3162771

perl-HTML-FormatText-WithLinks-AndTables.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 1 Parag AN(पराग) 2011-07-05 04:57:29 UTC
Review:
+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3162771
+ rpmlint output is
perl-HTML-FormatText-WithLinks-AndTables.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
perl-HTML-FormatText-WithLinks-AndTables.src: W: spelling-error %description -l en_US multi -> mulch, mufti
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ source verified as (sha1sum)
b585e7e616c41f5ab1e8d142fbd9007f6337e7d0  HTML-FormatText-WithLinks-AndTables-0.01.tar.gz
b585e7e616c41f5ab1e8d142fbd9007f6337e7d0  ../SOURCES/HTML-FormatText-WithLinks-AndTables-0.01.tar.gz

+ make test
All tests successful.
Files=3, Tests=2,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.12 cusr  0.01 csys =  0.15 CPU)
+ Package perl-HTML-FormatText-WithLinks-AndTables-0.01-2.fc15.noarch
Provides: perl(HTML::FormatText::WithLinks::AndTables) = 0.01
Requires: perl(HTML::FormatText::WithLinks) perl(HTML::TreeBuilder) perl(base) perl(strict) perl(warnings)


APPROVED.

Comment 2 Parag AN(पराग) 2011-07-05 04:58:32 UTC
If planning this package only for devel then you should remove
1) buildroot tag
2) cleaning of buildroot in %install
3) %clean section
4) defattr(-,root,root,-)

Comment 3 Ruediger Landmann 2011-07-27 05:31:04 UTC
Thanks Parag!

New Package SCM Request
=======================
Package Name: perl-HTML-FormatText-WithLinks-AndTables
Short Description: Converts HTML to Text with tables intact
Owners: rlandmann
Branches: f14 f15 el6
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2011-07-27 10:05:26 UTC
Git done (by process-git-requests).

Comment 5 Petr Pisar 2011-09-13 16:22:22 UTC
Package Change Request
======================
Package Name: perl-HTML-FormatText-WithLinks-AndTables
New Branches: f16
Owners: rlandmann
InitialCC: perl-sig

Please create branch for F16 as this one does not exist and we need it for rebuilding this package against new Perl in this branch. Current build inherited from F15 cannot be installed into F16 system.

Comment 6 Gwyn Ciesla 2011-09-13 16:51:24 UTC
Git done (by process-git-requests).