Bug 716940

Summary: [vdsm] vdsm keeps on running Stats function after getting VIR_ERR_NO_DOMAIN(42)
Product: Red Hat Enterprise Linux 6 Reporter: David Naori <dnaori>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact: yeylon <yeylon>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.1CC: abaron, bazulay, dnaori, fsimonce, hateya, iheim, mgoldboi, srevivo, ykaul
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-28 19:23:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vdsm log none

Description David Naori 2011-06-27 14:14:13 UTC
Created attachment 510099 [details]
vdsm log

Description of problem:
when killing a vm stats Thread gets "libvirtError: Domain not found" and still keeps on running.

Thread-56159::ERROR::2011-06-27 15:22:19,117::utils::371::vm.Vm::(collect) vmId=`0f6e0767-272e-4739-a963-b164dc08c43f`::Stats function failed: 
...
libvirtError: Domain not found: no domain with matching uuid '0f6e0767-272e-4739-a963-b164dc08c43f'


Thread-56159::ERROR::2011-06-27 15:22:24,121::utils::371::vm.Vm::(collect) vmId=`0f6e0767-272e-4739-a963-b164dc08c43f`::Stats function failed: <AdvancedStatsFunction _sampleNet at 0x24a13b0>
....
libvirtError: Domain not found: no domain with matching uuid '0f6e0767-272e-4739-a963-b164dc08c43f'


Version-Release number of selected component (if applicable):
vdsm-4.9-76.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.kill -9 qemu process 
  
Actual results:
vdsm keeps on trying to get statistics on a killed vm.

Expected results:
vdsm should stop stats thread when getting VIR_ERR_NO_DOMAIN (42)

Additional info:
full log attached

Comment 2 Federico Simoncelli 2011-06-28 14:46:28 UTC
Could it be that this was fixed by:

Related to BZ#705297: have a single virEventLoopPure thread
http://gerrit.usersys.redhat.com/625

It doesn't reproduce after applying the patch.

Comment 3 Dan Kenigsberg 2011-06-28 19:23:32 UTC
for a moment I thought that it could have nice if the stats thread knew that it should not continue polling after the domain no longer exists. but I'm not sure at all about it, and as you say - the underlying issue of lost events is solved. let's close.