Bug 717053

I believe we discussed this a while back probably after this bug was opened.  This text was meant to summarize the changeset contents (i.e. what the user added to the changeset).  

It was not meant to show the 'effective contents', that is what all packages are added as a result of the changeset contents.  The new page I think makes this somewhat more apparent, but please let me know if it doesn't.

I tried to verify this defect with following katello build:
[root@dhcp201-167 ~]# rpm -qa | grep katello
katello-cli-0.1.5-1.git.15.654a7df.fc15.noarch
katello-0.1.70-1.git.7.ca8d03c.fc15.noarch

Here are my observations:

1. I created a changeset and added a product in to changeset, however I couldn't able to see the count of product/repositories/packages in changeset. Is it expected ?

2. If I traverse into a product by double clicking on the product in left pane, 
I can see following entries:

- Errata
- Packages
- Repositories
- Distributions

However +Add is only available for 'Repositories', not for others. Is it expected behaviour ?

3. If click on +Add under 'Repositories' to add a repo ( not a product), I can see the following entries in changeset
 - Errata(0)
 - Repositories(1)
 - Undefined(0)

here why the last option is displayed as 'undefined(0)', looks like something missing here. 

Please see the attached screenshot (repo_add.png)

Created attachment 520043 [details]
Entries in changeset after adding a repo ( not proudct)

Hey Sachin,

1)  Yes.  The changeset view is showing what you have added.  In that case you added a complete product, so we don't show you the individual components.

2) I believe that was a bug that was fixed (we weren't making sure the product was in the next environment properly).  Although I'm not certain your exact steps, was the full product already in the changeset before you did that?

3) I wasn't able to reproduce this, but see my uncertainty about #2 above.

FYI:

Before you can promote a repo/package/errata, the product must have been promoted to the next environment at some point.  The easiest way to do this is:

1.  Add a product
2.  Add a Repo
3.  DO NOT SYNC THE REPO
4.  Promote the product
5.  Sync the repo
6.  You should now be able to add packages to teh changeset.

Other notes:

Once you add a full product to a changeset, you should not be able to add parts of it (package, errata, repo).  

The only way you should be able to add a package/repo/errata to a changeset is if:

a) There is a next environment
b) The product is already in the next environment
c) The package/repo/errata is not already in the next environment for that product
d) The entire product is not already added to the changeset
e) a changeset is selected

The issue i fixed above is fixed in f743c122455b44bc6d9053d628b76bd824bb1d73   katello-0.1.71-1

Thanks for a nice summary in comment4.

> 2) I believe that was a bug that was fixed (we weren't making sure the product
> was in the next environment properly).  Although I'm not certain your exact
> steps, was the full product already in the changeset before you did that?

No, full product was not already in changeset. I created a changeset and tried to add repositories with +Add. 
Now with latest build (katello-0.1.71-1), the +Add is not available for Repositories.


> 1.  Add a product
> 2.  Add a Repo
> 3.  DO NOT SYNC THE REPO
> 4.  Promote the product
> 5.  Sync the repo
> 6.  You should now be able to add packages to teh changeset.

Yes, now with above steps I can add packages to the changeset ( see pkg_add.png).

Created attachment 520339 [details]
This screenshot shows the +Add for packages.

Created attachment 520343 [details]
package count as per the added pkgs in changeset

getting rid of 6.0.0 version since that doesn't exist