Bug 717110

Summary: Use /etc/login.defs to define a 'system' account instead of hard-coding 500 (PackageKit)
Product: [Fedora] Fedora Reporter: Miloslav Trmač <mitr>
Component: PackageKitAssignee: Richard Hughes <richard>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: jonathan, k.georgiou, rhughes, richard, smparrish, theinric
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: PackageKit-0.6.17-2.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-29 14:00:42 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 717109    
Attachments:
Description Flags
Code to parse /etc/login.defs none

Description Miloslav Trmač 2011-06-28 00:02:11 EDT
Description of problem:
src/pk-transaction-extra.c:pk_transaction_extra_check_library_restart categorizes UIDs as system/session using a hard-coded value 500.  Please use UID_MIN from /etc/login.defs for this; we plan to change the boundary.

Please let me know if you want me to prepare a patch.

Version-Release number of selected component (if applicable):
PackageKit-0.6.15-2.fc16
Comment 1 Miloslav Trmač 2011-06-28 00:03:55 EDT
Created attachment 510191 [details]
Code to parse /etc/login.defs

This demonstrates the proper way to parse /etc/login.defs .
Comment 2 Richard Hughes 2011-06-28 09:53:17 EDT
commit 8cb69128cd85d630cbac45fc9d593e22420ce3ba
Author: Richard Hughes <richard@hughsie.com>
Date:   Tue Jun 28 14:52:16 2011 +0100

    Do not hardcode the UID_MIN as 500. Fixes rh#717110

There's a new upstream release in 6 days, so I'll include this fix in F15 and rawhide then. Thanks for pointing out the problem.

Richard.
Comment 3 Miloslav Trmač 2011-07-20 12:25:12 EDT
Thanks a lot; could you make sure commit 5456681c29753439766700f5dc431a4a1cf72a2e will get into Fedora 16 as well, please?
Comment 4 Kostas Georgiou 2011-07-21 06:36:40 EDT
system accounts are the ones below SYS_UID_MAX not below UID_MIN. UID_MIN is only the minimum that useradd uses, external user accounts (ldap) can still be below UID_MIN.
Comment 5 Miloslav Trmač 2011-07-21 07:06:56 EDT
(In reply to comment #4)
> system accounts are the ones below SYS_UID_MAX not below UID_MIN. UID_MIN is
> only the minimum that useradd uses, external user accounts (ldap) can still be
> below UID_MIN.

Similarly, external system accounts can be outside of the SYS_* range.  PackageKit considers each account to be either a system or user account, there is no "uknown" category.
Comment 6 Miloslav Trmač 2011-08-09 11:39:08 EDT
(In reply to comment #3)
> Thanks a lot; could you make sure commit
> 5456681c29753439766700f5dc431a4a1cf72a2e will get into Fedora 16 as well,
> please?
Commit is included in rawhide PackageKit-0.6.17-2, so rawhide should be fine.  Thanks!
Comment 7 Fedora End Of Life 2013-04-03 15:42:49 EDT
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19