Bug 717112

Summary: Use /etc/login.defs to define a 'system' account instead of hard-coding 500 (authconfig)
Product: [Fedora] Fedora Reporter: Miloslav Trmač <mitr>
Component: authconfigAssignee: Tomas Mraz <tmraz>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: k.georgiou, steve.traylen, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: authconfig-6.1.15-1.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-22 11:35:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 717109    

Description Miloslav Trmač 2011-06-28 04:10:51 UTC 
Description of problem:
authinfo.py (and authconfig.8) categorize UIDs as system/user using a hard-coded value 500.  Please use UID_MIN from /etc/login.defs for this; we plan to change the boundary.

See attachment 510191 [details] for the proper way to parse /etc/login.defs.

Please let me know if you want me to prepare a complete patch.

Version-Release number of selected component (if applicable):
authconfig-6.1.14-2.fc16
Comment 1 Tomas Mraz 2011-06-28 06:25:24 UTC 
No need to prepare a complete patch.
Comment 2 Kostas Georgiou 2011-07-21 10:31:00 UTC 
Shouldn't authconfig use SYS_UID_{MIN,MAX} instead of UID_MIN?
Values below UID_MIN can still be user accounts...
Comment 3 Miloslav Trmač 2011-07-21 11:09:15 UTC 
(In reply to comment #2)
> Shouldn't authconfig use SYS_UID_{MIN,MAX} instead of UID_MIN?
> Values below UID_MIN can still be user accounts...

Similarly, values outside of SYS_* can be system accounts.  In practice, SYS_UID_MAX defaults to (UID_MIN-1), so UID_MIN is the variable more likely to be present in login.defs - and checking UID_MIN is already a de facto standard.