Bug 717166

Summary: Wrong filenames generated in TAGS file
Product: [Fedora] Fedora Reporter: Robin Green <greenrd>
Component: ctagsAssignee: Than Ngo <than>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 17CC: than, wmeier
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-01 18:08:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Robin Green 2011-06-28 08:56:31 UTC
Description of problem:
If you check out the trunk version of ctags and run make TAGS in it, incorrect filenames are generated in the TAGS file, e.g. parsh.h. This occurs regardless of whether the trunk version of ctags or the Fedora version is used.

Version-Release number of selected component (if applicable):
ctags-5.8-3.fc15.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Check out ctags from SVN
2. ctags -e ./*
  
Actual results:
TAGS file contains some incorrect filenames

Expected results:
TAGS file should contain all correct filenames

Additional info:
I loaded the TAGS file with emacs-23.2-19.fc15.x86_64 and it failed to open the corrupted filename when I tried to do M-. on a symbol that happened to be defined in that file.

Comment 1 Robin Green 2011-06-28 08:57:46 UTC
Also filed upstream as https://sourceforge.net/tracker/?func=detail&aid=3247256&group_id=6556&atid=106556

Comment 2 Robin Green 2012-07-22 07:49:15 UTC
No longer present in Fedora 17.

Comment 3 Bill Meier 2012-09-30 21:53:23 UTC
(In reply to comment #2)
> No longer present in Fedora 17.

> No longer present in Fedora 17.

Actually, the problem is still present in Fedora 17.   :)

I encountered the exact same problem using ctags 5.8-7 on an up-to-date Fedora 17.

After downloading the ctags source, building and debugging ctags, I found that the problem is caused by the following strcpy() 
in the ctags file 'routines.c' function 'absolute_filename()':

	else if (slashp [2] == PATH_SEPARATOR  ||  slashp [2] == '\0')
	{
		strcpy (slashp, slashp + 2);
		continue;
	}

(This is code which removes ./  from a pathname string)

As noted in the strcpy documentation: "...this function has undefined results if the strings overlap"  which they clearly do in this case.

Searching all the ctags top-level source files for strcpy() usage shows at least 2 other cases where strcpy is copying overlapping strings.

So: this bug should be re-opened !

I will add this information to the upstream report linked to in Comment #1.

Comment 4 Fedora End Of Life 2013-07-04 06:33:50 UTC
This message is a reminder that Fedora 17 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 17. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '17'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 17's end of life.

Bug Reporter:  Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 17 is end of life. If you 
would still like  to see this bug fixed and are able to reproduce it 
against a later version  of Fedora, you are encouraged  change the 
'version' to a later Fedora version prior to Fedora 17's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2013-08-01 18:08:32 UTC
Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.