Bug 717555
| Summary: | Review Request: packagedb-cli - A CLI for pkgdb | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre-YvesChibon <pingou> |
| Component: | Package Review | Assignee: | Elad Alfassa <elad> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | elad, notting, package-review, pahan |
| Target Milestone: | --- | Flags: | elad:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | packagedb-cli-1.0.0-6.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-12 05:06:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pierre-YvesChibon
2011-06-29 08:38:25 UTC
I have uploaded the sources somewhere as a temporary solution for the review Spec URL: http://pingou.fedorapeople.org/RPMs/packagedb-cli.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/packagedb-cli-1.0.0-2.fc15.src.rpm I'll do the review! -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers + Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
+ No rpmlint output.
packagedb-cli.noarch: W: spelling-error Summary(en_US) pkgdb -> pkg db, pkg-db, pkg
packagedb-cli.noarch: W: no-manual-page-for-binary pkgdb-cli
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Can be ignored.
+ final provides and requires are sane:
packagedb-cli-1.0.0-2.fc15.noarch.rpm
packagedb-cli = 1.0.0-2.fc15
=
/usr/bin/python
python-argparse
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
SHOULD Items:
+ Should build in mock.
- Should build on all supported archs
+ Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
APPROVED!
--
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
New Package SCM Request ======================= Package Name: packagedb-cli Short Description: A CLI for pkgdb Owners: pingou Branches: f14 f15 el6 InitialCC: I am seeing if we could make it run on el5, there seem to be some dependency issue with argparse. I redo a SCM request later if needed. Git done (by process-git-requests). packagedb-cli-1.0.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/packagedb-cli-1.0.0-3.fc14 packagedb-cli-1.0.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/packagedb-cli-1.0.0-3.fc15 packagedb-cli-1.0.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/packagedb-cli-1.0.0-3.el6 New Package SCM Request ======================= Package Name: packagedb-cli Short Description: A CLI for pkgdb Owners: pingou Branches: el5 InitialCC: Since we will have a python26-argparse in epel5, I am requesting the el5 branch as well Since this has already been created, submit this as a Package Change request. Indeed sorry about that. Package Change Request ====================== Package Name: packagedb-cli New Branches: el5 Owners: pingou Git done (by process-git-requests). No worries! Thanks! python26-argparse-1.2.1-3.el5, packagedb-cli-1.0.0-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python26-argparse-1.2.1-3.el5,packagedb-cli-1.0.0-4.el5 packagedb-cli-1.0.0-3.el6 has been pushed to the Fedora EPEL 6 testing repository. python26-argparse-1.2.1-3.el5,packagedb-cli-1.0.0-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python26-argparse-1.2.1-3.el5,packagedb-cli-1.0.0-6.el5 packagedb-cli-1.0.0-6.fc15 has been pushed to the Fedora 15 stable repository. packagedb-cli-1.0.0-6.fc14 has been pushed to the Fedora 14 stable repository. python26-argparse-1.2.1-3.el5, packagedb-cli-1.0.0-6.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. packagedb-cli-1.0.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository. |