Bug 717787

Summary:	[apache] Even when Augeas Support is disabled, the plug-in continues to use Augeas
Product:	[Other] RHQ Project	Reporter:	Larry O'Leary <loleary>
Component:	Plugins	Assignee:	Lukas Krejci <lkrejci>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.0.1	CC:	hrupp, lzoubek
Target Milestone:	---
Target Release:	JON 3.0.0, RHQ 4.3.0
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-07 19:17:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	678340, 745494

Description Larry O'Leary 2011-06-29 20:55:06 UTC

Even when Augeas support is disabled for an Apache Web Server resource, the Apache plug-in continues to use Augeas in some circumstances.

The loadResourceConfiguration() method of the following classes seems to be the offender:

   ApacheIfModuleDirectoryComponent
   ApacheIfModuleComponent
   ApacheDirectoryComponent


The expectation is that if Augeas Support is disabled in the plug-in configuration, no method will attempt to use it.

Comment 1 Charles Crouch 2011-08-05 13:11:08 UTC

(8:07:49 AM) lkrejci: ccrouch-afk: ah, no, it isn't - i lied to you the last time ;) the components mentioned in the description just lack the check for augeas being allowed by the user and just use it..
(8:08:04 AM) ccrouch: sigh
(8:08:18 AM) ccrouch: ok, thats going to need fixing too then
(8:08:41 AM) lkrejci: but this is only a issue if you do: 1) inventory apache, 2) enable augeas, 3) change your mind and disable it after a while
(8:08:58 AM) ccrouch: good point
(8:09:11 AM) lkrejci: k, i'll take a look at it now
(8:09:18 AM) lkrejci: shouldn't be a problem
(8:09:30 AM) ccrouch: ok so we should fix it, but its not a blocker i guess
(8:09:55 AM) lkrejci: yea, i don't think it's a blocker

Comment 2 Charles Crouch 2011-09-30 21:55:42 UTC

remove superfluous blocks bz's

Comment 3 Lukas Krejci 2011-11-01 16:09:39 UTC

master: 6f1004a715406241dea681a6a8f6e7d9b5c280f0
release_jon3.x: 761e4c3202da7faabf9a6a1226a6769496d5dac9

    BZ 717787 - Making sure augeas is only ever used if the apache resource
    is allowed to do so.
    
    Improved the confusing error message when augeas was not enabled that
    stated that apache version is not supported or augeas is not available,
    when in fact neither could be true.

Comment 4 Mike Foley 2012-02-07 19:17:34 UTC

changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE