Bug 717860

Summary:	Static array overrun
Product:	Red Hat Enterprise Linux 6	Reporter:	Michal Luscon <mluscon>
Component:	oprofile	Assignee:	William Cohen <wcohen>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-tools-bugs
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.1	CC:	pmuller
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	oprofile-0.9.6-18.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 17:56:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Michal Luscon 2011-06-30 08:25:37 UTC

Description of problem:

/daemon/opd_ibs.c:636, 652 - Function strncat may cause overrunning of string variable filename if length of session_dir is greater than 1005.

Version-Release number of selected component (if applicable):
0.9.6-12

Additional info:

These defects were probably introduced by Red Hat patches.

Comment 2 William Cohen 2011-07-08 21:04:09 UTC

This code is directly from the upstream oprofile, so the problem also exists in newer upstream versions of oprofile:

http://oprofile.git.sourceforge.net/git/gitweb.cgi?p=oprofile/oprofile;a=blob;f=daemon/opd_ibs.c;

Comment 3 William Cohen 2011-07-26 15:37:27 UTC

Patch has been reviewed and will be in upstream oprofile. Built RHEL-6 oprofile with patch.

Comment 6 Petr Muller 2011-09-30 15:25:42 UTC

cppcheck shows this is fixed:

:: [17:24:25] ::    --- /tmp/tmp.IhRdJzrB62/output1.log	2011-09-30 17:24:05.228962036 +0200
:: [17:24:25] ::    +++ /tmp/tmp.IhRdJzrB62/output2.log	2011-09-30 17:24:24.258111476 +0200
:: [17:24:25] ::    @@ -3,2 +2,0 @@
:: [17:24:25] ::    -daemon/opd_ibs.c@line 636: Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it) [error]
:: [17:24:25] ::    -daemon/opd_ibs.c@line 652: Dangerous usage of 'filename' (strncpy doesn't always 0-terminate it) [error]


Moving to VERIFIED

Comment 7 errata-xmlrpc 2011-12-06 17:56:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1712.html