| Summary: | Review Request: rubygem-hike - Find files in a set of paths | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-30 14:08:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vít Ondruch
2011-06-30 12:25:20 UTC
I'll take this for a review. - Please update to the latest version of gem (currently 1.2.1). - The specfile you provided differs from the specfile in SRPM (just the two comments in %check, but please fix this). - License is MIT, not GPLv2+ or Ruby. - Please consider updating to the new standard of Rubygems packaging for Rawhide with Ruby 1.9.3 [1] (and please build the package with new Ruby, not the old one - use f17-ruby target in Koji). - Otherwise the package looks good, but I'd like to see it once more after it gets updated to the latest version, then I'll gladly approve it. [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby (In reply to comment #2) > - Please update to the latest version of gem (currently 1.2.1). Done > - The specfile you provided differs from the specfile in SRPM (just the two > comments in %check, but please fix this). Done > - License is MIT, not GPLv2+ or Ruby. Done > - Please consider updating to the new standard of Rubygems packaging for > Rawhide with Ruby 1.9.3 [1] (and please build the package with new Ruby, not > the old one - use f17-ruby target in Koji). Done > - Otherwise the package looks good, but I'd like to see it once more after it > gets updated to the latest version, then I'll gladly approve it. > > [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby Spec URL: http://people.redhat.com/vondruch/rubygem-hike.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-hike-1.2.1-1.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745471 The package looks good now => APPROVED. Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-hike Short Description: Find files in a set of paths Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). |