Bug 718249

Summary:	iwhd fails to compile against jansson-2.1
Product:	[Retired] CloudForms Cloud Engine	Reporter:	Chris Lalancette <clalance>
Component:	iwhd	Assignee:	Jim Meyering <meyering>
Status:	CLOSED ERRATA	QA Contact:	Martin Kočí <mkoci>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.0.0	CC:	akarol, dajohnso, deltacloud-maint, jrd, mkoci, ssachdev
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-15 19:55:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Chris Lalancette 2011-07-01 14:59:37 UTC

Description of problem:
Fedora Rawhide contains jansson version 2.1.  Unfortunately, between jansson 1.3 and 2.1 they broke the API; at least json_load_file changed from:

json_t *json_load_file(const char *path, json_error_t *error);

to:
json_t *json_load_file(const char *path, size_t flags, json_error_t *error);

(there may be others, I didn't go further than that)

We'll need to fix this before we can build iwhd into rawhide.

Comment 1 Jim Meyering 2011-07-01 15:28:30 UTC

Thanks.  I scoped that out a week or so ago.
Just needs 0 for flags.  I'll add an autoconf test and the code to deal with it.

Comment 2 Jim Meyering 2011-07-04 08:20:08 UTC

Here's the patch:

http://thread.gmane.org/gmane.comp.lib.iwhd.devel/696

Comment 3 Jim Meyering 2011-09-26 14:39:25 UTC

This is a mere build problem that has been fixed in iwhd since v0.96-3-g6bbc52f (aka 0.97).

If anyone wants to keep it open, speak up soon.
Otherwise, I'll close it tomorrow.

Comment 4 wes hayutin 2011-09-26 14:59:19 UTC

err.. put in on_qa :)
thanks :)

Comment 5 Jim Meyering 2011-09-26 15:36:28 UTC

done

Comment 7 Jim Meyering 2011-11-02 09:45:04 UTC

Wes,

This bug (like any build failure) should have been closed long ago.
It was a mere compilation failure, and was worked around
via configure.ac changes that appeared in v0.96-3-g6bbc52f.

Leaving this bug open has encouraged people to spend time checking whether
it is indeed fixed.  That time is 100% wasted.

Then, I get the occasional question about how to check whether
this "bug" is really fixed.  More wasted time.

Comment 8 wes hayutin 2011-11-02 13:03:31 UTC

this bug has been on_qa since 9/26

meyering	2011-09-26 11:36:28 EDT	 Status	MODIFIED	ON_QA
pm-rhel	2011-09-28 13:18:42 EDT	 Flags		cloudforms-1.0.0?
pm-rhel	2011-09-28 13:50:42 EDT	 Flags		pm_ack?
whayutin	2011-10-07 08:47:50 EDT	 Version	1.0	cloudforms‑1.0.0
meyering	2011-11-02 05:45:04 EDT	 CC		jrd

any questions from 9/26 on should have been addressed to qe.

Comment 9 Martin Kočí 2011-11-04 10:17:03 UTC

Successfully compiled with jsson 2.1. 

[root@mkoci-f16 iwhd]# iwhd --version
iwhd (iwhd) 1.0.1-1945
[root@mkoci-f16 iwhd]# rpm -qa|grep -e jansson
jansson-2.1-1.fc16.x86_64
jansson-devel-2.1-1.fc16.x86_64

moving the bug to VERIFIED.

Comment 11 errata-xmlrpc 2012-05-15 19:55:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0589.html