Bug 718267

Summary: Enabling valgrind builds for arm arch
Product: [Fedora] Fedora Reporter: William Cohen <wcohen>
Component: valgrindAssignee: Jakub Jelinek <jakub>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dodji, jakub
Target Milestone: ---   
Target Release: ---   
Hardware: arm7   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-18 00:26:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Changes to valgrind.spec to allow build on arm architecture
none
Patch to allow building valgrind on arm none

Description William Cohen 2011-07-01 15:47:13 UTC
Created attachment 510890 [details]
Changes to valgrind.spec to allow build on arm architecture

Description of problem:

Valgrind has support for the arm processor, but the valgrind.spec does not allow it to build.


Version-Release number of selected component (if applicable):

valgrind-3.6.1-4.

How reproducible:

Everytime


Steps to Reproduce:
1. Download the valgrind srpm and install
2. Install any build dependencies for valgrind
3. rpmbuild -ba
  
Actual results:

Error about unsupported architecture


Expected results:

rpmbuild build the valgrind binary rpm.


Additional info:

Was able to modify the valgrind.spec and produce an valgrind binary rpm on a armv7 machine running fc13. However, it would probably be better to have the valgrind configure file be less picky about the arm architectures.

Comment 1 William Cohen 2012-02-20 19:30:38 UTC
Created attachment 564513 [details]
Patch to allow building valgrind on arm

Took the attached patch to build valgrind on arm.  In addition to trying it out on local Fedora 15 arm machine was also able to build on f15 and f17 scratch builds on koji:

f15  http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=453363
f17 http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=453386

One downside of the patch is it turns off testing for the arm platform.  When doing the testing ends up with failing on the neon128 test in valgrind-3.7.0/none/tests/arm:


make[5]: Entering directory `/media/greatplains/wcohen/rpmbuild/BUILD/valgrind-3
.7.0/none/tests/arm'
gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../.. -I../../../include -I../../../cor
egrind -I../../../include -I../../../VEX/pub -DVGA_arm=1 -DVGO_linux=1 -DVGP_arm
_linux=1 -DVGPV_arm_linux_vanilla=1  -Winline -Wall -Wshadow -g  -g -O0 -mcpu=co
rtex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb -Wno-long-long -O2 -g -pipe -Wall 
-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -march=armv7
-a -mfpu=vfpv3-d16  -mfloat-abi=hard -Wno-pointer-sign -fno-stack-protector -c -
o neon128-neon128.o `test -f 'neon128.c' || echo './'`neon128.c
gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../.. -I../../../include -I../../../cor
egrind -I../../../include -I../../../VEX/pub -DVGA_arm=1 -DVGO_linux=1 -DVGP_arm
_linux=1 -DVGPV_arm_linux_vanilla=1  -Winline -Wall -Wshadow -g  -g -O0 -mcpu=co
rtex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb -Wno-long-long -O2 -g -pipe -Wall 
-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -march=armv7
-a -mfpu=vfpv3-d16  -mfloat-abi=hard -Wno-pointer-sign -fno-stack-protector -c -
o neon64-neon64.o `test -f 'neon64.c' || echo './'`neon64.c
{standard input}: Assembler messages:
{standard input}:70: Error: selected FPU does not support instruction -- `vmov.i
8 q0,#0x55'
{standard input}:71: Error: selected FPU does not support instruction -- `vmov.i
32 q0,#0x7'
{standard input}:118: Error: selected FPU does not support instruction -- `vmov.
i32 q0,#0x7'
....

Think need to disable the neon128 and neon64 tests.

Comment 2 William Cohen 2012-04-18 00:26:44 UTC
Arm Fedora 17 has valgrind-3.7.0-2.fc17.armv7hl and it appears to work.