Bug 718270
| Summary: | Review Request: openr2 - MFC/R2 telephony signaling protocol over E1 lines | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeffrey C. Ollie <jeff> |
| Component: | Package Review | Assignee: | Itamar Reis Peixoto <itamar> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | itamar, package-review, tcallawa |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-06 14:23:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jeffrey C. Ollie
2011-07-01 15:54:51 UTC
looks good, any reason to not use %{_sysconfdir} for /etc ?
will you build asterisk with openr2 support ?
(In reply to comment #1) > looks good, any reason to not use %{_sysconfdir} for /etc ? No, just an oversight. I'll fix it up after I get back from lunch. > will you build asterisk with openr2 support ? Yes, otherwise I wouldn't bother :) Are you able to do some actual testing? I don't have the appropriate DAHDI hardware and am in the wrong part of the world anyway... we are in the wrong part of the world, because we still use E1 lines. I don't have hardware to test too, I am poor, after everything ok we will send a mail to mailling list's (moy, asterisk-br, etc...) and ask the people to try it. can you make rpmlint happy ? [itamar@itamarssd openr2]$ rpmlint /home/itamar/rpmbuild/RPMS/x86_64/openr2-1.3.1-1.fc15.x86_64.rpm /home/itamar/rpmbuild/RPMS/x86_64/openr2-devel-1.3.1-1.fc15.x86_64.rpm /home/itamar/rpmbuild/RPMS/x86_64/openr2-debuginfo-1.3.1-1.fc15.x86_64.rpm openr2.x86_64: W: spelling-error %description -l en_US spandsp -> spandex, Span, span openr2.x86_64: W: spelling-error %description -l en_US libteletone -> limestone openr2.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+ openr2.x86_64: W: file-not-utf8 /usr/share/doc/openr2-1.3.1/doc/intro-openr2-es.alaw openr2.x86_64: W: no-manual-page-for-binary r2dtmf_detect openr2-devel.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+ openr2-debuginfo.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+ openr2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/openr2-1.3.1/src/openr2/queue.h openr2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/openr2-1.3.1/src/queue.c openr2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/openr2-1.3.1/src/openr2/r2engine.h openr2-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/openr2-1.3.1/src/r2engine.c 3 packages and 0 specfiles checked; 4 errors, 7 warnings. (In reply to comment #3) > we are in the wrong part of the world, because we still use E1 lines. > > I don't have hardware to test too, I am poor, after everything ok we will send > a mail to mailling list's (moy, asterisk-br, etc...) and ask the people to try > it. I can understand. > can you make rpmlint happy ? > openr2.x86_64: W: spelling-error %description -l en_US spandsp -> spandex, > Span, span > openr2.x86_64: W: spelling-error %description -l en_US libteletone -> limestone These are false positives, the original spelling is correct. > openr2.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+ > openr2-devel.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+ > openr2-debuginfo.x86_64: W: invalid-license LGPLv2, LGPLv2+, GPLv2+ The files are an odd mixture of licenses, so I think that the license line is correct, rpmlint's being too picky. > openr2.x86_64: W: file-not-utf8 > /usr/share/doc/openr2-1.3.1/doc/intro-openr2-es.alaw Another false positive, this is a binary sound file. > openr2.x86_64: W: no-manual-page-for-binary r2dtmf_detect It'd be nice to have a manual page, but I really don't know enough to even attempt to write one. > openr2-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/openr2-1.3.1/src/openr2/queue.h > openr2-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/openr2-1.3.1/src/queue.c > openr2-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/openr2-1.3.1/src/openr2/r2engine.h > openr2-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/openr2-1.3.1/src/r2engine.c I'm not sure it's worth patching these files to have the correct address. Don't use commas as separators in the License field, use "LGPLv2 and LGPLv2+ and GPLv2+" (In reply to comment #5) > Don't use commas as separators in the License field, use "LGPLv2 and LGPLv2+ > and GPLv2+" Good to know. Spec URL: http://jcollie.fedorapeople.org/openr2.spec SRPM URL: http://jcollie.fedorapeople.org/openr2-1.3.1-2.fc15.src.rpm * Fri Jul 1 2011 Jeffrey Ollie <jeff> - 1.3.1-2 - Replace commas in license field with 'and's - use _sysconfdir macro instead of hardcoded path (In reply to Jeffrey C. Ollie from comment #7) are you still interested on this ? (In reply to Itamar Reis Peixoto from comment #8) > (In reply to Jeffrey C. Ollie from comment #7) > > are you still interested on this ? I am not. |