Bug 718745

Summary: cpuplugd: fix daemon startup race
Product: Red Hat Enterprise Linux 6 Reporter: IBM Bug Proxy <bugproxy>
Component: s390utilsAssignee: Dan Horák <dhorak>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: azelinka, jkachuck, jmarko, ovasik
Target Milestone: rc   
Target Release: ---   
Hardware: s390x   
OS: All   
Whiteboard:
Fixed In Version: s390utils-1.8.2-37.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 17:45:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 684953    
Attachments:
Description Flags
s390-tools-rhel6-cpuplugd_pid_race.patch none

Description IBM Bug Proxy 2011-07-04 13:30:39 UTC 
Description: cpuplugd: fix daemon startup race

Symptom:     Multiple cpuplugd instances might be started concurrently.

Problem:     There is a race between the pid file check/creation and daemon startup.

Solution:    Use flock() around pid file check/creation and daemon startup.

Patch :  s390-tools-rhel6-cpuplugd_pid_race.patch


Verification : 

The patch has been tested, fixes the problem, and will be included in the next upstream release of the s390-tools.

With best regards,
     Hendrik
Comment 1 IBM Bug Proxy 2011-07-04 13:30:44 UTC 
Created attachment 511191 [details]
s390-tools-rhel6-cpuplugd_pid_race.patch
Comment 6 IBM Bug Proxy 2011-09-16 17:00:43 UTC 
------- Comment From sachinp.com 2011-09-16 12:56 EDT-------
Tested against RHEL 6.2 alpha. This issue has been fixed.

# cat /etc/issue
Red Hat Enterprise Linux Server release 6.2 Beta (Santiago)
Kernel \r on an \m

# uname -r
2.6.32-195.el6.s390x

# cpuplugd -c /etc/sysconfig/cpuplugd
# cpuplugd -f -c /etc/sysconfig/cpuplugd
pid file /var/run/cpuplugd.pid still exists.
This might indicate that an instance of this daemon is already running.
#
Comment 8 errata-xmlrpc 2011-12-06 17:45:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1525.html