Bug 718802

Summary: MinGW-gtk3 does not install gdk/win32 headers
Product: [Fedora] Fedora Reporter: greg.hellings
Component: mingw-gtk3Assignee: Kalev Lember <kalevlember>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 15CC: erik-fedora, kalevlember
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: mingw-gtk3-3.0.11-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-22 19:29:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch against GTK3 to install gdk/win32 headers none

Description greg.hellings 2011-07-04 17:48:36 UTC
Created attachment 511219 [details]
Patch against GTK3 to install gdk/win32 headers

Description of problem:
Upstream package fails to install the gdk/win32/ headers as referenced by the installed header gdk/gdkwin32.h. This makes it impossible to build packages which rely on specific gdk backends.  This problem is novel to GTK3 and does not affect GTK2.

Version-Release number of selected component (if applicable):
3.0.10-1

How reproducible:
Install mingw-gtk3 package and view directory listing for /usr/i686-pc-mingw32/sys-root/mingw/include/gtk-3.0/gdk/.  There is no win32/ subfolder, which inclusion of the gdkwin32.h file requires to operate properly.

Steps to Reproduce:
1. Build gtk3
2. Install
3. Try to build a package which relies on them (e.g. webkitgtk)
  
Actual results:
Compile fails because of missing win32/ headers.

Expected results:
E.g. webkitgtk should be buildable against GTK+3

Additional info:
I have created a patch and built an rpm (3.0.10-2) which fixes this problem.  Binary and source rpms along with the modified spec file and the patch itself can be found at http://dl.thehellings.com/mingw32-gtk3.  The patch is attached here as well.

Comment 1 Kalev Lember 2011-07-08 21:41:53 UTC
Thanks Greg! You should definitely consider becoming a Fedora package maintainer.

I've built 3.0.11 with your changes for both F15 and rawhide. Are you planning to submit the patch upstream too?

Comment 2 Fedora Update System 2011-07-08 21:53:06 UTC
mingw-gtk3-3.0.11-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/mingw-gtk3-3.0.11-1.fc15

Comment 3 greg.hellings 2011-07-08 22:21:02 UTC
Kalev, I have submitted the patch upstream, but have received no comment as yet.  You can track the issue here: https://bugzilla.gnome.org/show_bug.cgi?id=653964.

I wouldn't want to maintain a package until I knew for sure I was going to use it. Until WebKitGTK fixes a related bug (including X11-only functionality through GDK) the software I work with will have to stay with gtk2.

Comment 4 Fedora Update System 2011-07-12 04:57:57 UTC
Package mingw-gtk3-3.0.11-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mingw-gtk3-3.0.11-1.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/mingw-gtk3-3.0.11-1.fc15
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2011-07-22 19:29:21 UTC
mingw-gtk3-3.0.11-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.